Well, it seems like a code smell - we pull the options resolver *out* of the action, resolve the options and then put them back *in*. It seems to me the unit shpuld be able to do this itself without *help* from the `BuilderUnit` class.

Wouter J <notifications@github.com> wrote:
>> @@ -63,6 +70,8 @@ public function existsAction(RouteStack
>$routeStack)
>>       */
>>      public function notExistsAction(RouteStack $routeStack)
>>      {
>> -        $this->notExistsAction->execute($routeStack);
>> +        $options =
>$this->existsAction->getOptionsResolver()->resolve($this->builderConfig['not_exists_action']['options']);
>> +
>> +        $this->notExistsAction->execute($routeStack, $options ?:
>array());
>
>I find this more "clean" than doing this each time in the
>`execute`/`providePath` methods. What is the benefit of doing this in
>the service class?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/symfony-cmf/RoutingAutoBundle/pull/61/files#r9201004

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.