assert*


On Wed, Feb 26, 2014 at 7:55 PM, Alex Gaynor <alex.gaynor@gmail.com> wrote:

> asset!
>
>
> On Wed, Feb 26, 2014 at 7:54 PM, Paul Kehrer <notifications@github.com>wrote:
>
>> In cryptography/hazmat/backends/openssl/backend.py:
>>
>> > +            pkey_ctx, evp_md)
>> > +        assert res > 0
>> > +
>> > +        res = self._backend._lib.EVP_PKEY_CTX_set_rsa_padding(
>> > +            pkey_ctx, self._padding_enum)
>> > +        assert res > 0
>> > +        data_to_verify = self._hash_ctx.finalize()
>> > +        self._hash_ctx = None
>> > +        res = self._backend._lib.EVP_PKEY_verify(
>> > +            pkey_ctx,
>> > +            self._signature,
>> > +            len(self._signature),
>> > +            data_to_verify,
>> > +            len(data_to_verify)
>> > +        )
>> > +        if res != 1:
>>
>> Looking at the implementation it appears we need to find a way to trigger
>> a non-zero error to maintain 100% code coverage when changing this to
>> handle errors. @public <https://github.com/public> have you looked at
>> this before? I just spent a little bit of time and it was not immediately
>> obvious to me how to do it...
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/675/files#r10111505>
>> .
>>
>
>
>
> --
> "I disapprove of what you say, but I will defend to the death your right
> to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
> "The people's good is the highest law." -- Cicero
> GPG Key fingerprint: 125F 5C67 DFE9 4084
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084