That is true. I'm okey with it if you correct so that while loop still
works.


On Thu, Jan 23, 2014 at 5:55 PM, Sascha Montellese <notifications@github.com
> wrote:

> In xbmc/network/upnp/UPnPPlayer.cpp:
>
> > @@ -283,6 +298,7 @@ int CUPnPPlayer::PlayFile(const CFileItem& file, const CPlayerOptions& options,
> >        }
> >      }
> >
> > +    timeout.Set(timeout.GetInitialTimeoutValue());
> >      NPT_CHECK_LABEL_SEVERE(WaitOnEvent(m_delegate->m_traevnt, timeout, dialog), failed);
> >
> >    } while(!timeout.IsTimePast());
>
> You're right but resetting it before the while loop would work. What I
> dislike about increasing the initial timeout is that it could happen that
> the first request (Stop) takes like 20 seconds and then you only have 10
> seconds left for the remaining calls to SetAVTransportURI, Play and
> repeated GetTransportInfo. Using one big timeout may cause random failures
> in one of those WaitOnEvent() calls depening on the timing.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/4058/files#r9119754>
> .
>