silly linter wants proper docstrings

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
linter wants an import in the docstring :(

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
remove unused import in debian uninstall

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
remove unused imports in fedora install

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
add a few noqa comments for (valid) unused imports

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
more noqa comments for valid unused imports in hosts

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
noqa comments for valid unused imports in util/paths

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
noqa comments for valid unused imports in conf/init

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
remove unused cfg object

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
fix unused imports in tests

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
add testenv for flake8 in tox

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
fix flake8 exclusions

Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
Merge pull request #206 from alfredodeza/8713

fixes all critical liniting errors
write_conf() overwrite logic fixed for python 2.6

Explicitly set dict_type to OrderedDict in conf.ceph.parse(): it only
became the default for RawConfigParser in Python 2.7).

Parse and re-serialize the existing config file before comparing its
contents with expected configuration to make sure that the order of
options in the file doesn't affect the comparison.

Only overwrite the file if it's contents is different and --overwrite
option was used. If the contents matches the expected configuration,
leave it untouched.

conf.ceph.write_conf() has been superceded by host.remote.write_conf()
and is not called from anywhere, so it is removed.

Closes-Bug: #1333814