Ok, I was unsure if I should use a really shady switch or if statements. 
I'll change it into if statements and then if time allows try to think 
of if there is any other control structure or way to rewrite it to make 
it more succinct.


On 3/16/14, 11:28 AM, Michael Holler wrote:
>
> In app/controllers/GitController.php:
>
> > +    }
> > +
> > +    /**
> > +     * buildMessage function
> > +     *
> > +     * Build an appropriate error message based on which parameters are null.
> > +     *
> > +     * @param string $user
> > +     * @param string $project
> > +     * @return string message
> > +     */
> > +    private function buildMessage($user, $project)
> > +    {
> > +        $exceptionMessage = "The following parameter(s) passed to the git controller function is(are) null: ";
> > +        $userNull = false;
> > +        switch(true)
>
> @samuelfrench <https://github.com/samuelfrench>, sorry I missed this 
> before, but this is not the right way to use a switch statement. 
> Please refactor into if statements instead.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/CSC495-2014/TeamworkEnglewoodGit/pull/144/files#r10640136>.
>