commit and sending pull request to merge the two parameter