Sorry I may not have used github poperly.
Indeed, I'm afraid you did not review the version of the pull request that
took Dustin's reviews into account.
(listofshellcommands does not exist anymore).
The good version is accessible there
https://github.com/buildbot/buildbot/pull/1045/
It consists of the three commits
https://github.com/yetanotherion/buildbot/commit/7c3ff5c6707daa4a10c6f45ba6211629086e1b5f
https://github.com/yetanotherion/buildbot/commit/922108ed101d36480993f3e611e15e7b42e0c8d7
https://github.com/yetanotherion/buildbot/commit/cd309d44195f282a33677833bcef1e16c061af24




2014/1/17 Stibbons <notifications@github.com>

> In master/buildbot/steps/listofshellcommands.py:
>
> > +        defined by the steps above.
> > +        """
> > +        warnings = []
> > +        all_res = []
> > +        if self.commands is None:
> > +            yield self.setStateStrings(["commands == None"])
> > +            defer.returnValue(results.EXCEPTION)
> > +        for arg in self.commands:
> > +            if not isinstance(arg, ShellArg):
> > +                yield self.setStateStrings([str(arg), "not", "ShellArg"])
> > +                defer.returnValue(results.EXCEPTION)
> > +            self.currCmd = arg.cmd
> > +            if not self.doIRunTheCommand(self.currCmd):
> > +                all_res.append(results.SKIPPED)
> > +                continue
> > +            # handle the log
>
> we already have steps with several log with the same name, it's just not
> readable
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/buildbot/buildbot/pull/1045/files#r8968541>
> .
>



-- 
Ion