Ticket Support

This is the implementation of tickets, as described in https://ripple.com/wiki/Multisign, which is required for M-of-N work.

A set of integrations tests to check ticket creation, lookup and deletion will be needed and will be pushed into this request as soon as they are done. 
There is no way to delete comments other than a force push - but he might
have force-pushed "the same" commit amended and it wouldn't show up.

We like your comments!  :-D

I filed a bug against this assert just now:
https://ripplelabs.atlassian.net/browse/RIPD-534

Wanna take this on?  It might be a nice way to do a small C++ changelist
and get into it...


On Wed, Aug 27, 2014 at 9:49 AM, sublimator <notifications@github.com>
wrote:

> In src/ripple/module/app/transactors/CancelTicket.cpp:
>
> > +    {
> > +        if (mTxnAccountID == sleTicket->getFieldAccount160 (sfTarget))
> > +            authorized = true;
> > +    }
> > +
> > +    // And finally, anyone can remove an expired ticket
> > +    if (!authorized && sleTicket->isFieldPresent (sfExpiration))
> > +    {
> > +        std::uint32_t const expiration = sleTicket->getFieldU32 (sfExpiration);
> > +
> > +        if (mEngine->getLedger ()->getParentCloseTimeNC () >= expiration)
> > +            authorized = true;
> > +    }
> > +
> > +    if (!authorized)
> > +        return tecCLAIM;
>
> This is still a problem, due to an assert in TransactionMeta::addRaw
> <https://github.com/ripple/rippled/blob/develop/src/ripple/module/app/tx/TransactionMeta.cpp#L229>
>
>  assert ((mResult == 0) || ((mResult > 100) && (mResult <= 255)));
>
> Any reason all my comments were deleted? Doesn't seem like there's been a
> force push
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ripple/rippled/pull/516/files#r16775506>.
>