On Mon, May 12, 2014 at 11:17 AM, Blake Griffith
<notifications@github.com>wrote:

> In distarray/dist/tests/test_distarray.py:
>
> >
> >      def test_from_global_dim_data_uu(self):
> > -        rows = 6
> > -        cols = 20
> > +        rows = 3
> > +        cols = 10
>
> the for loops can be replaced with fromarray.
>

+1.


> But I don't see any reason to make this test so large.
>
Under what definition of "large" is a 120-element array considered so?  We
should have a few 10**6 element arrays in the normal test suite for some
small scaling tests.  The performance and profiling test suite should work
with 10**9 element arrays routinely to make obvious any communication or
performance bottlenecks.

Please keep this test at 120 elements at least, and when you or someone
else implements it on top of fromarray with slicing, we should bump that
number up a few orders of magnitude.


>  —
> Reply to this email directly or view it on GitHub<https://github.com/enthought/distarray/pull/369/files#r12538308>
> .
>



-- 
Kurt W. Smith, Ph.D. <ksmith@enthought.com>
Enthought, Inc. <http://www.enthought.com>  | 512.536.1057