Yeah I agree, I’m not sure why I had that followed a perfectly good max() statement in the next line. Dumb mistake on my part.

From: Aman Kapur [mailto:notifications@github.com]
Sent: Tuesday, February 18, 2014 12:13 PM
To: griffint/SoftwareDesign
Subject: Re: [SoftwareDesign] Hw3 graded (#1)


In hw3/gene_finder.py:

>

> -    dnaInput = 'ATGCATGCCTAGGTAG'

> -    expectedOutput = "['ATGCATGCC','ATGCCTAGG']"

> +        # YOUR IMPLEMENTATION HERE

> +        if (len(find_all_ORFs_both_strands(dna)))>2:

Why this line? what if there is only 1 ORF strand in the dna ? No max then ?

You failed some tests only because of this.

This is all that was needed

   return max(find_all_ORFs_both_strands(dna), key=len)

—
Reply to this email directly or view it on GitHub<https://github.com/griffint/SoftwareDesign/pull/1/files#r9831815>.