Pushed with comments addressed.

Thanks & Regards
-Harshmeet


On Mon, Jan 27, 2014 at 4:55 PM, Rich Lane <notifications@github.com> wrote:

> In modules/icmpa/module/src/icmpa_handlers.c:
>
> > +        if (of_packet_in_match_get(packet_in, &match) < 0) {
> > +            AIM_LOG_ERROR("ICMPA: match get failed");
> > +            return INDIGO_CORE_LISTENER_RESULT_PASS;
> > +        }
> > +        port_no = match.fields.in_port;
> > +    }
> > +
> > +    if (port_no > MAX_PORTS) {
> > +        AIM_LOG_ERROR("ICMPA: Port No: %d Out of Range %d", port_no, MAX_PORTS);
> > +        return INDIGO_CORE_LISTENER_RESULT_PASS;
> > +    }
> > +
> > +    /*
> > +     * Identify if the reason is valid for ICMP Agent to parse the packet
> > +     */
> > +    switch (reason) {
>
> The hardware isn't going to send you all of these reasons.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/floodlight/switchlight-common/pull/14/files#r9213677>
> .
>