I understand the reasoning behind this change. I went back and forth on
whether or not to extract that out of the resources macro. I fixed the
output for the PR. I'll rebase and resubmit.


On Tue, Feb 4, 2014 at 9:07 AM, Chris McCord <notifications@github.com>wrote:

> In test/phoenix/router/routing_test.exs:
>
> > @@ -37,6 +54,9 @@ defmodule Router.RoutingTest do
> >      get "static/images/icons/*image", FilesController, :show
> >
> >      resources "comments", CommentsController
> > +    resources "posts", PostsController, except: [ :destroy ]
> > +    resources "sessions", SessionsController, only: [ :new, :create, :destroy ]
>
> Looks like you'll need to rebase before we can merge this. I refactored
> the resources macro to do all code generation within itself. It's a stretch
> on function length, but I want to try and keep the code generation as
> straight forward as possible for now.
> https://github.com/phoenixframework/phoenix/blob/master/lib/phoenix/router/mapper.ex#L121-L150
>
> This PR as is would squash those changes I think.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/phoenixframework/phoenix/pull/28/files#r9420971>
> .
>