mapping type? is mapping type the right naming here maybe call it `name` rather than type?