move and rename app_collator

fixes: PLAT-802

test-plan:
specs should pass

Change-Id: I24ebaa0ea14e7c7491e67ea22a8134988d5985b7
Reviewed-on: https://gerrit.instructure.com/45588
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
only broadcast grade changes to active students

fixes CNVS-16300

test plan:
  - invite two new students to a course (dont accept yet)
  - grade both of these students on an assignment
    - both should receive notifications
  - as one of the students, reject the invitation
    to join the course. as the other, accept the invite
  - change "display grade as" in the assignment
    settings (eg from letter grade to pass/fail)
    - check that student who is still invited to the
      course got a new notification of a grade change
      while the other student did not

Change-Id: I8e07d07df0a137c2f3d69b45052a601eef4225f2
Reviewed-on: https://gerrit.instructure.com/45787
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Fixed fragile scheduler selenium spec

Fixes CNVS-16219

Test Plan:
* Run /spec/selenium/teacher_schedule_spec.rb and make sure everything passes
 the commit message for your changes. Lines starting

Change-Id: Ib23a8e2ac5a577eb09f6343532aecad537efff9b
Reviewed-on: https://gerrit.instructure.com/45870
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
fix capitalization for feature flag titles

Change-Id: Ifc41738ca66e050668f8551ae49900e0dd0933da
Reviewed-on: https://gerrit.instructure.com/45907
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes bug when accessing restricted folder

fixes CNVS-17408

Test Plan:
* Enable "Better File Browsing" feature flag
* Go to any course's Files page
1. As a teacher, add a folder with a file in it
2. Make the folder restricted with a "FROM" date for tomorrow
3. Do NOT restrict the file in the folder (also breaks if restricted, but it breaks more when not restricted)
4. Open the /files page as a student
5. Click on the folder that is restricted (on the left panel)
6. An error should appear stating that the student doesn't
   have access to the folder

Change-Id: I5d5ef47463d490f987046d908e056fffe4653700
Reviewed-on: https://gerrit.instructure.com/45858
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
datafixup to populate role overrides when adding a new permission

refs #CNVS-17512

Change-Id: I4e44fb41cc245e9dafaa1f0c4532d1882c4bbffe
Reviewed-on: https://gerrit.instructure.com/45805
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
section and override dependent destroy

fixes CNVS-15503

test plan:
  - turn DA on
  - create a course section
  - add an due date for this section and this section only
    on an assignment, graded discussion topic, and quiz
  - destroy this section
  - when you come back to the assignment edit page
    the due date for this section is gone
  - a warning telling the user that
    no students are assigned should exist
    - when you click to add a due date, this
      warning goes away
  - check that the discussion topic & quiz edit
    pages behave similarly

Change-Id: I079a025789f657fa55c66943daac14447ae288a3
Reviewed-on: https://gerrit.instructure.com/45667
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
visualize focusing on a tree

fixes CNVS-17257

when navgating a file tree, focus wouldn't visually show up on the ul
tree. This removes the css attribute preventing this from happening.

Test Plan

Given you are working on new files
And you are only using the keyboard
Then use tabs to navigate to the file folder directory
And you should see that the tree ul should have a focus highlight around it.

Change-Id: Ifacf64eef1f30af4e6f7611c5a21720b0e67978f
Reviewed-on: https://gerrit.instructure.com/45819
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fix add role overrides for new permission datafixup

ignore existing permissions if they already exist

Change-Id: Ia60fada44132da0139ef18cf3906423ce3f3009d
Reviewed-on: https://gerrit.instructure.com/45943
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
bump encrypted_cookie_store

fixes CNVS-16684

Change-Id: I49c45ac4a251b6919723bd5bdebb2d66d8dcb33f
Reviewed-on: https://gerrit.instructure.com/44638
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
address new sel_rel gaps, fix nil @other_section

we saw some gaps in the tests, and I've now addressed
them. we believe the amount of differentiated
assignment specs we have count as a solid regression
run

Change-Id: Id43da19a354331572a07984a7fc8e5cf414be054
Reviewed-on: https://gerrit.instructure.com/45673
Reviewed-by: Sean Lewis <slewis@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
fix account notification course roles

test plan:
* create an account notification ("Announcement") through
 the account settings page
* should be able to specify built-in and custom course roles
 to restrict the notification to
* the restrictions should work (should test on both
site admin and non-site-admin account)

closes #CNVS-17410

Change-Id: I07d98aa78ff7468b43b8c9c42b81883439f94fb4
Reviewed-on: https://gerrit.instructure.com/45766
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
make external tool modal accessible

fixes CNVS-13119

test plan:
  - with a screenreader, go to the assignment edit page
  - under submission type, select External Tool
  - you should be able to navigate to a screenreader only
    button that says Open External Tool Url Options
  - when you click it, the modal should open and read the text
    starting with the "Select a tool from the list below"

Change-Id: I6a9226fd3453af014bc11783ef9c7f582d30ddfa
Reviewed-on: https://gerrit.instructure.com/45778
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
don't count deleted enrollments in grade calculations

fixes CNVS-16876

Test plan:
  * make a course with 3 enrollments
  * delete one of the enrollments
  * grade the other 2 enrollments on an assignment
  * the assignment stats in 'assignment details' in gb2 should be
    correct
  * the assignment stats on the students grade page should match

Change-Id: Id750f2ff767d83318542bdfca5f2994867b95c8a
Reviewed-on: https://gerrit.instructure.com/45098
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Official Canvas Header color

Back in the day when we flattened canvas we gave it an interium
color while we were getting our variables in order.

This adds a variable for the header background color, and changes
it to the offical $canavs-secondary variable color

Test plan:

- Log into Canvas, the color in the header should change slightly

Change-Id: I0eaacb757d3ebcf895fcb186b94643f99f18af22
Reviewed-on: https://gerrit.instructure.com/45378
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Color contrast - Navigation/Global

fixes CNVS-16047

This makes some changes to the navigation and dashboard area
for meeting accessibility color ratios and making things consisitent.

Test Plan:
- Badges on Dashboard
We've tweaked the badge colors to make them consistent and
accessible (those blue bubbles that appear for grades, inbox,
and dashboard notifications)

Reference screens:
http://screencast.com/t/Ew1sz8HQKRV
http://screencast.com/t/Sk85Coyamaz

- We've changed the badge numbers that were appearing on the
recent activity to just be blue dots vs numbers and blue dots
(this appears on both a course dashboard and the main login dash)

http://cl.ly/image/2k3p2U3s0y3O

- Stop Masquerading button was fixed with the buttons update

Change-Id: Ife4842508d705ac616411d0edced6d81de67e9be
Reviewed-on: https://gerrit.instructure.com/45521
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fix js error in jqueryui menu.js customization

test plan:
 1. go to course settings / import content into this course
 2. select "Copy a Canvas Course"
 3. enter text into the autocomplete box on the right side
 4. click a course in the list
 5. check the js console and /error_reports and ensure there was
    not an error logged such as
    https://canvas.instructure.com/error_reports/37169475

fixes CNVS-17544

Change-Id: I05227cd8eb7534b48580d7a182a842d5af566d11
Reviewed-on: https://gerrit.instructure.com/45915
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
SubmissionComments for student groups share a group_comment_id

fixes CNVS-12630

- Wrote tests around Assignment#update_submission to document
  its behavior.
- When an Assignement updates a submission with a comment for
  a group, the SubmissionComments created share a group_comment_id.

Change-Id: Idd83005c71b9d98be8e001b667b37e45901ebb80
Reviewed-on: https://gerrit.instructure.com/44754
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Reviewed-by: Sean Lewis <slewis@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
add delete api for tool proxy

PLAT-794

test-plan:
do a DELETE http action agains "#{context}s/:#{context}_id/tool_proxies/:tool_proxy_id"
it should mark the tool as deleted

Change-Id: I31398bbf960b50b0b90e5d9a0e06e8b25544904e
Reviewed-on: https://gerrit.instructure.com/45523
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
api for updating tool proxies

fixes PLAT-793

test-plan
*do a PUT http action against "#{context}s/:#{context}_id/tool_proxies/:tool_proxy_id"
with the param workflow_state = 'disabled'
*It should update the workflow state

Change-Id: I8c9f59a4a5216a4794fd01310ff69c195e58988e
Reviewed-on: https://gerrit.instructure.com/45547
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>