Yes the code looks very similar but it is using Kafka-08 APIs underneath
which are not backward compatible with Kafka 07


On Mon, Jun 2, 2014 at 4:53 PM, P. Oscar Boykin <notifications@github.com>
wrote:

> In
> tormenta-kafka-08/src/main/scala/com/twitter/tormenta/spout/KafkaSpout.scala:
>
> > + *    limitations under the License.
> > + */
> > +
> > +package com.twitter.tormenta.spout
> > +
> > +import com.twitter.tormenta.scheme.Scheme
> > +import storm.kafka.{KafkaSpout => StormKafkaSpout, SpoutConfig, ZkHosts}
> > +
> > +/**
> > + *  @author Oscar Boykin
> > + *  @author Sam Ritchie
> > + *  @author Mansur Ashraf
> > + */
> > +
> > +
> > +class KafkaSpout[+T](scheme: Scheme[T], zkHost: String, brokerZkPath: String, topic: String, appID: String, zkRoot: String, forceStartOffsetTime: Int = -1)
>
> can you comment if this code needs kafka08? It looks quite similar to the
> 07 code. I wonder if we could avoid the duplication at all.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/twitter/tormenta/pull/52/files#r13309345>.
>