Revert "adding tests for error formatting of errors class"

This reverts commit 47fbaf67a7afa98ec35a324be04366fffca11882.
Revert "Don't print array literals in error messages"

This reverts commit 4f8b874e3e86425eaaba606f9152f03acdd4da38.
Replace before(:all) hooks with before(:each) in unit tests

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
reverting error message related commits which broke build

investigating further

Merge branch 'check_if_revert_fixes_stacks_error'
Extract EventRepository for Event

So we can use this to decorate application events with logging for [#61987212]

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Inline class methods on Event

Since they have been moved to EventRepository now [#61987212]

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Fixing tests

Accindentally pushed previous commit

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Inject the EventRepository in apps and spaces controller

Follow existing pattern to inject event repository dependency

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Split AppEventRepository and SpaceEventRepository

[#61987212]

Signed-off-by: Maria Shaldibina <mariash@pivotallabs.com>
Memoize app_event_repository instance

  * this is currently needed for testing

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Move app.update loggregator message to AppEventRepository

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Move loggregator emit message on app create to AppEventRepository

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Move loggregator emit message on app delete to AppEventRepository

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Emit loggregator message on app exit

[#61987212]

Signed-off-by: Aram Price <aprice@pivotallabs.com>
Fix test to check parameter attributes

The Sequel "reload" updates the object and simple comparison fails
although all attributes are the same. Instead we only compare app guid
and updated attributes.
Revert "reverting error message related commits which broke build"

This reverts commit c4aaa22625663bb02bdfcbb1865b9834e8fd0f2a, reversing
changes made to 7f3c0ae66bb7658c78e72a80e74a687f6088e64f.
Revert "Replace before(:all) hooks with before(:each) in unit tests"

This reverts commit 7f3c0ae66bb7658c78e72a80e74a687f6088e64f.
Add checksum testing to prevent accidental changes to compatibility tests [finishes #63344256]
Move service broker api tests [finishes #63344456]
Move broker api spec helpers to their own file [finishes #62436340]