trying to follow best practices with rspec