Cc pdlogs 61

Updated after review comments.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against craft_ent_definitions.h.
Added more comments to craft_ent_definitions.h.  
Kept the name PDLog (Problem Definition Log) as this describes what the classes are.  They enable Enhanced Node Troubleshooting which is what they do.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
A type name was added for the PDLog enum.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
Added CL_SCRIPT_ID to PDNodeType.
Provided separate pdlog.h which defines the PDLog classes, and, cpp-common_ent_definitions.h which defines the PDLog instances for cpp-common.  The other files are named similarly, sprout_ent_definitions.h, homestead_ent_definitions.h, and so on.
David

From: Eleanor Merry [mailto:notifications@github.com]
Sent: Wednesday, December 17, 2014 9:59 AM
To: Metaswitch/cpp-common
Cc: David Collins
Subject: Re: [cpp-common] Cc pdlogs 61 (#214)


In include/craft_ent_definitions.h<https://github.com/Metaswitch/cpp-common/pull/214#discussion-diff-21980920>:

> +    dcealog(buf);

> +  };

> +

> +};

> +

> +

> +/// Description of the following PDLog definitions content

> +/**********************************************************

> +/ log_id

> +/ severity

> +/ Description: (formatted)

> +/ Cause:

> +/ Effect:

> +/ Action: \n separated list

> +**********************************************************/

> +static const PDLog CL_DIAMETER_START

Can you separate the definitions below into a new file (so that all the PDlog definitions are stored in similarly named file in each repo)

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/cpp-common/pull/214/files#r21980920>.