Make Scaladoc actually exit with non-zero exit code in case of errors,
as its docs say it does.
Merge pull request #4032 from dturner-tw/dturner/scaldoc-exit-code

Make Scaladoc actually exit with non-zero exit code in case of errors, as its docs say it does