addressing feedback/updated description
added user warnings
added advanced option
Merge for retab
Retab changes for PR #1910
Merge pull request #1 from tabassassin/retab/pr/1910

Retab/pr/1910
Fixed java_signed_applet for Java 7u51
Add module for CVE-2010-2343
Fix ROP NOP address and reduce/remove NOPs
Fix and improve reliability
Fix invalid session ID bug

This fix should work seamlessly with #2952.
Merge remote-tracking branch 'upstream/master' into beug/session

Conflicts:
	lib/msf/base/simple/post.rb
Fix payload size
Replace unnecessary NOP sled with random text
Remove unnecessary NOPs
Minor code formatting
Use a more correct error message

-1 is a valid session ID, even though it's a fake one.
Increase the size of the NOP sled
Fix issue with getenv failing

The call to `getenv` failed when `%` or `$` were used because of the
differences between Meterpreter handling and MSF handling.

Meterpreter effectively ignores (ie. strips out) the platform-specific
characters which are used for environment variables. In the `getenv`
call, MSF was invoking `getenvs` and getting a full hash of values, then
attempting to index into the hash using a string which may be "polluted"
with those platform-specific characters. This meant that there was a
discrepency between what was returned and what was used to index and
as a result, the value would come out as `nil`.

For example, calling `getenv('%FOO%')` would result in a hash with
`{'FOO'=>'bar'}`, so looking for '%FOO%' in this result would yield
nothing.

This commit changes this so that the name is ignored and the first
value is returned.
Fix Uninitialized Constant RequestError

[SeeRM #8765] NameError uninitialized constant