Happy to be leading the vanguard :-) I was writing for consistency (and you picked me up on the Lazy bit being inconsistent ;-))

________________________________
From: Brendan Forster <notifications@github.com>
Sent: 20 January 2014 22:43
To: octokit/octokit.net
Cc: Andy Cross
Subject: Re: [octokit.net] Implement Repository Hooks (#313)


In Octokit.Tests/Clients/RepositoryHooksClientTest.cs:

> +                client.Hooks.Get("fake", "repo");
> +
> +                connection.Received().GetAll<RepositoryHook>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/hooks"));
> +            }
> +
> +            [Fact]
> +            public async Task EnsuresNonNullArguments()
> +            {
> +                var client = new RepositoriesClient(Substitute.For<IApiConnection>());
> +
> +                await AssertEx.Throws<ArgumentNullException>(async () => await client.Hooks.Get(null, "name"));
> +                await AssertEx.Throws<ArgumentNullException>(async () => await client.Hooks.Get("owner", null));
> +            }
> +        }
> +
> +        public class TheGetByIdMethod


Take your time, I'm just reviewing bits and pieces as it evolves.

I just skimmed for other examples where we check and throw this exeption but we haven't written tests for them.

Happy to leave it for now...

-
Reply to this email directly or view it on GitHub<https://github.com/octokit/octokit.net/pull/313/files#r9021239>.