parameters need to be checked