Remove warn log in quota function on API layer

An API layer function in quotas print warn message when in input
is not valid, it's useless since an exception will be raised.

Change-Id: I707416aae29e56ad1c7d2cc55ca8c662bf5547f5
Deprecate nova-manage flavor subcommand

The nova client already has the following flavor commands:

flavor-access-add    Add flavor access for the given tenant.
flavor-access-list   Print access information about the given flavor.
flavor-access-remove Remove flavor access for the given tenant.
flavor-create        Create a new flavor
flavor-delete        Delete a specific flavor
flavor-key           Set or unset extra_spec for a flavor.
flavor-list          Print a list of available 'flavors' (sizes of
flavor-show          Show details about the given flavor.

This covers what nova-manage flavor was providing so let's deprecate the
legacy nova-manage subcommand and mark it for removal in the K release.

There is not a bug or blueprint for this. The flavor subcommand is
completely duplicated in nova client. It is accessing the database
directly and we want to move to using flavor objects which would go
through conductor. So this could be considered part of the objects
conversion for flavors.

For some other commands like service, db and host it makes sense to
leave those so you can access the database before the api service is
running, but that's not the case for flavors.

UpgradeImpact: nova-manage flavor command is deprecated, use nova client

Change-Id: I8709bc9af4e490142e44c6dc61fd0aaa3a392b68
DescribeInstances in ec2 shows wrong image-message

If one instance boots from a volume,
the value of 'image_id' by 'DescribeInstances' in ec2,
will be a wrong number.

The value of 'image_ref' for this type of instances, is '', not None.
So the original protected codes can't take efforts.

Change-Id: I8c5e1c626f2b7873e7720f3615db1ee1ec6c681a
Closes-Bug: #1278696
Spice proxy config setting to be read from the spice group in nova.conf

All spice configuration should be read from the spice group
in the nova config. As it's currently being done in the nova.spice
module.
Renaming spicehtml5proxy_{host, port} parameters to
html5proxy_{host, port}

DocImpact
Change-Id: I36c014c8b8a0796cda494f9450a1fc30104504a1
Closes-Bug: #1308418
replace NovaException with VirtualInterfaceCreate when neutron fails

Currently NovaException is being raised by the _neutron_failed_callback()
and being treated in a try..except block that wraps the _crate_domain method.
The exception is too generic and will catch any exceptions, which are
subclasses of NovaException (for example: ObjectActionError),
making the domain variable not be defined and will mask the original exception.

Suggesting to raise and catch the VirtualInterfaceCreateException and
treat the domain destroy and cleanup with save_and_reraise_exception
in the except block.

Change-Id: Ic972e286ded4e8b9d79ce1b0aa514bb4623d5f0b
Set default auth_strategy to keystone

It doesn't make much sense to default to no authentication in
production. We should always have production ready defaults.

DocImpact Changing default config option.

Change-Id: Ife63dc7ab680fcf0588d95c98fc9f29901485c64
Don't translate debug level logs in nova.network

Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since nova doesn't support lazy translation yet).

Change-Id: I8973992d0dd2348f9c657c3caa1cc9c7d79a4c7b
Merge "DescribeInstances in ec2 shows wrong image-message"
Remove a bogus and unnecessary docstring

A docstring in the Cinder API check_attached method was wrong, and is
quite unnecessary as well since the method is pretty much self
explanatory.

Change-Id: I179611bc627d49a4ffaa58f27dd1b7dcb33c6870
Merge "Don't translate debug level logs in nova.network"
Fix typo in unit tests

A couple of unit tests misspelt 'factory'.

Fixes bug 1312776

Change-Id: I1c3a7ba63671aff4d866d0501c941ce637238546
Merge "Deprecate nova-manage flavor subcommand"
Merge "Remove a bogus and unnecessary docstring"
Merge "replace NovaException with VirtualInterfaceCreate when neutron fails"
Merge "Fix typo in unit tests"
Merge "Set default auth_strategy to keystone"
Merge "Remove warn log in quota function on API layer"
Merge "Spice proxy config setting to be read from the spice group in nova.conf"
Adding image multiple location support

Images now support multiple locations within its metadata and it may be
stored on more than one backend storage. Nova should add a layer to
transparently handle image preparing and removing for an instance by the
best approach/location, and it should allow administrators to configure
the image handler pipeline with the order who preferred to the layer.

Also, based on this structure we could implement particular sub-class in
relevant hypervisor layer with more advanced functions, such as CoW
making, snapshot capturing and etc. in future.

Implement bp: image-multiple-location
DocImpact

Change-Id: Idce8d21ae37bfdbb28a2567120a83d1061061904
Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
Move libvirt RBD utilities to a new file

This will make it easier to share rbd-related code with
cinder and glance. Port the applicable unit tests over
from cinder.

Change-Id: I5bf08da87daf1d98f326f21cf33aba68aa830785
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>