ok as @rande ping me on the fact that I should implement tests I will take this in my next PR