Fix checkpatch errors carried over from 2.1

2.1 had several checkpatch errors unresolved.

This does not touch FSAL_GLUSTER.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Remove check for NULL return from alloca in FSAL_VFS and FSAL/commonlib.c

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Improve debug of FSAL_VFS create_handle

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Remove unecessary retval test in vfs_get_root_handle (fixes CID24704)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
call freeaddrinfo in add_client (fixes CID24706)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
don't overwrite b_left in set_const_log_str (fixes CID24711 and CID24716)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Return CACHE_INODE_BAD_TYPE as error in cache_inode_setattr (fixes CID24721)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Simplify getting clientid_owner for LAYOUT ops (fixes CID24720)

The LAYOUT ops used to call get_clientid_owner to get the clientid owner
for the clientid associated with the current session. Since the ops MUST
be within a session, and thus the session and it's associated clientid
MUST be valid, we don't need to lookup, we can just look into the
associated clientid for it's owner.

This resolves any reference counting issues, and happens to clear a
Coverity bug with an ignored return result.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Merge remote-tracking branch 'origin/for-2.2-dev-2' into next

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Merge remote-tracking branch 'phdeniel/pull_request' into next

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Merge remote-tracking branch 'linuxbox2/next-cov' into next

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
V2.2-dev-2

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Repairs broken config parsing for FSAL_PROXY.

This commit repairs the broken config parsing for FSAL_PROXY.
The syntax for the proxy specific arguments is as follow:
PROXY
{
	# FSINFO arguments (cansettime, link_support, ...
	(..)
        Remote_Server
        {
                Srv_Addr = server.remote.net ;
                Retry_SleepTime = 10;
                Use_Privileged_Client_Port = true;
		(...)
        }
}

Change-Id: Ic8902bde5e7ea363e8f31194016a62d237517d90
Signed-off-by: Philippe DENIEL <philippe.deniel@cea.fr>
Lustre/PNFS: refurbishes the :Lustre/pNFS configuration

This commit changes the way pNFS configuration is managed.
The pNFS configuration is no more a dedicated LUSTRE_PNFS block.
The configuration goes into a sub-block of FSAL dedicated configuration
block "LUSTRE"

The syntax becomes:
LUSTRE
{
	# fsalfsinfo related items
	xattr_access_rights = 0700;
	(...)

	PNFS
	{
            DATASERVER
            {
                    DS_Addr = ganesha_ds2.mynetwork.myhome ;
                    DS_Port = 2049 ;
                    DS_Id = 1 ;
            }
            DATASERVER
            {
                    DS_Addr = ganesha_ds2.mynetwork.myhome ;
                    DS_Port = 2049 ;
                    DS_Id = 2 ;
	    }
	  #more Dataservers if wantred
	  (...)
	}
}

Export specific configuration remain the same:
    EXPORT
    {
      (...)
      FSAL {
        name = "LUSTRE";
        PNFS
         {
            Stripe_Unit = 1048576;
            pnfs_enabled = true;
            DATASERVER
            {
                    DS_Id = 2 ;
            }
            DATASERVER
            {
                    DS_Id = 1 ;
            }
         }
      }
     (...)

IMPORTANT REMINDER:
On each pNFS data server, a "pNFS aware" ganesha server should run.
pNFS can be enabled for some exports and disabled for others.
Different exports can use different sets of DSs.

FSAL/pNFS: updates informaiton in  src/config_samples/config.txt

Signed-off-by: Philippe DENIEL <philippe.deniel@cea.fr>
FSAL_LUSTRE: fixes CID24050 (unchecked return code)

Change-Id: If3b76813de992b48f972c1df79e6c64a4ec9d503
Signed-off-by: Philippe DENIEL <philippe.deniel@cea.fr>
Comments useless code. This code will be uncommented as code will be added in the config's commit functions.

FSAL_PROXY and FSAL_LUSTRE have block with *_commit functions, to be called during parsing to check configuration item.
Those functions are currently empty are are basically placeholders.
Setting a variable withut using it triggers a compilation error in Maintainer mode, so I commented this.
This piece of code will be uncommented as "flesh" will come in this part of the code.

Change-Id: I266d8000fa689e3f62e2d97b94f5cc9f69c54e9f
Signed-off-by: Philippe DENIEL <philippe.deniel@cea.fr>
Exports configuration: adds "All Anonymous" as an synonym for "All Squash"

The Squash=All statement replaces the old "ALL_ANONYMOUS" from older configuration file.
Adding Squash=All_Anonymous makes the change more intuitive to sysadms.

Change-Id: I29bfe7b908a675c21522905449dbf7db424974ad
Signed-off-by: Philippe DENIEL <philippe.deniel@cea.fr>
specfile: only declare utils if we build it

Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>