Fix authnz_ldap package name on el7
Merge pull request #911 from mcanevet/fix/el7/mod_authnz_ldap

Fix authnz_ldap package name on el7
Clean-up hash lookup and avoid local undef var
Add params to proxy_pass to provide ProxyPass key=value connection settings
cleanup condition
passenger concat needs to be wrapped in a check
(MODULES-1457) apache::vhost: SSLCACertificatePath can't be unset

The SSLCACertificatePath is always set. The check for @ssl_certs_dir only
covers "undef". As there is a default value in ::apache::params for
ssl_certs_dir it needs to be overriden with an empty string.

Right now the _ssl.erb template outputs 'SSLCACertificatePath ""' for an empty
string, which triggers a failing reload of httpd.

This patch just adds a "&& @ssl_certs_dir != ''" to the condition.

On a Puppet master passenger vhost it's probably  security relevant setting,
as it enables all system CA signed certificates access.

Related patch: https://github.com/puppetlabs/puppetlabs-apache/pull/787
allow disabling default vhosts under 2.4

when disabling the default vhost(s) under 2.4, there's nothing to
include in $sites-enabled/, which causes the following error:

    The apache2 configtest failed.
    Output of config test was:
    apache2: Syntax error on line 46 of /etc/apache2/apache2.conf: No
    matches for the wildcard '*' in '/etc/apache2/sites-enabled', failing
    (use IncludeOptional if required)
    Action 'configtest' failed.
    The Apache error log may have more information.

by using IncludeOptional (as recommended), we allow the use of httpd as
simple web server, with single purpose configuration, without having to
define a (default) vhost.
Added ssl_protocol parameter to apache::mod::ssl

makes it easier to fix things like POODLE
fix ssl_protocol docs to be in line with code
Support parameters along with proxy_pass
Support keywords along with proxy_pass, use hash for params
Add some tests for ProxyPass parameters
Linting and adding some tests

Adding tests
Satisfy doesn't work with apache 2.4

The ability to use the more complex Require* syntax for apache 2.4
will be added eventually, but Satisfy shouldn't be tested as that is
deprecated in apache.
wsgi_chunked_request doesn't work on lucid
Update metadata

Fix PE compatibility, update issues URL, and fix requirements to match
output from PMT.
MODULES-1446: mod_version is now builtin

while we are not loading it (by default), we should make it easier for
people transitioning their configuration from 2.2 to 2.4 to find issues:
thus adding a warning when someone tries to load mod_version.

---

things i have learned during this pr:

× @hunner: There is no '&&' in puppet; only 'and'*

× add puppet to PATH, so vim can check syntax. thanks @mhaskel
especially for the patience.

*zuhl.
Relying on missing fact

Ubuntu 10.04 with PE3.3 is missing the operatingsystemmajrelease fact,
so check either operatingsystemmajrelease or operatingsystemrelease.
Fixes indentation of versioncmp