New menus hidden behind feature flag

@ctsims Agreed and updated

On Wed, Dec 17, 2014 at 2:19 PM, ctsims <notifications@github.com> wrote:
>
> In app/src/org/commcare/android/view/MenuListEntryView.java
> <https://github.com/dimagi/commcare-odk/pull/89#discussion-diff-21996240>:
>
> > -    /*
> > -     * (non-Javadoc)
> > -     * @see android.view.View#onWindowVisibilityChanged(int)
> > -     */
> > -    @Override
> > -    protected void onWindowVisibilityChanged(int visibility) {
> > -        super.onWindowVisibilityChanged(visibility);
> > -        if (visibility != View.VISIBLE) {
> > -            if (mAudioButton != null) {
> > -                mAudioButton.endPlaying();
> > -            }
> > -        }
> > -    }
> > -
> > -}
> > +package org.commcare.android.view;
>
> Gotcha. Hm, not 100% sure i'm with you there. If you look at some of the
> usages of TextImageAudioView around we use it in a couple of contexts (demo
> mode warning, double management action, detail display view) where it's not
> representing a menu list entry.
>
> I agree that "TextImageaudioView" is pretty fucking bad, though, that's
> for sure.
>
> Maybe we should take a step back to fundamentals a bit and think of what
> it's doing rather than where it's used and call it something like
> "HorizontalMediaView", and call the new one "GridMediaView"? They both
> fundamentally do the same thing in different ways (Display some subset of
> Text, Audio, Image, video, etc) and we might be more included to re-use
> them and genericize them if we thought about them that way.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dimagi/commcare-odk/pull/89/files#r21996240>.
>