Moved potion static functions to EntityEffect to create splash potions through world
Fixed indentations, removed redundant init code in SplashPotionEntity.cpp
SplashPotionEntity: Use `const cItem &` instead of a cItem
Merge pull request #1232 from mc-server/splash-entity

Moved potion static functions to EntityEffect to create splash potions through the world