nit: it would be nice to update the comment now that we handle two different types