Discussed on IRC< I think it's fine.


On Wed, Apr 2, 2014 at 11:36 PM, Alex Stapleton <notifications@github.com>wrote:

> In docs/hazmat/primitives/asymmetric/dsa.rst:
>
> > @@ -23,6 +33,18 @@ DSA
> >                          ``subgroup_order``, or ``generator`` do
> >                          not match the bounds specified in `FIPS 186-4`_.
> >
> > +    .. classmethod:: generate(key_size, backend)
> > +
> > +        Generate a new ``DSAParameters`` instance using ``backend``.
> > +
> > +        :param int key_size: The length of the modulus in bits. For keys
> > +            generated in 2014 this should be `at least 2048`_. (See page 41.)
>
> It's page 41 of the PDF but not the page that is numbered 41 in the
> written page numbers. Which wrong number would you prefer?
> … <#145264d5c12f3ac3_>
> On 2 April 2014 22:12:06 Alex Gaynor <notifications@github.com> wrote: >
> @@ -23,6 +33,18 @@ DSA > ``subgroup_order``, or ``generator`` do > not
> match the bounds specified in `FIPS 186-4`_. > + .. classmethod::
> generate(key_size, backend) > + > + Generate a new ``DSAParameters``
> instance using ``backend``. > + > + :param int key_size: The length of the
> modulus in bits. For keys > + generated in 2014 this should be `at least
> 2048`_. (See page 41.) I think this page number is wrong, I can't find the
> number 2048 on page 41 :-) --- Reply to this email directly or view it on
> GitHub: https://github.com/pyca/cryptography/pull/739/files#r11228038
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/739/files#r11240439>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084