BUG-1611: fix SimpleDateFormat

The format used is incirrect and it makes no sense to instantiate the
utility all over again. Use the yang-common utility instead.

Change-Id: I0dbd80db6726aeb80e6666a330964d58bc08455c
Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1611: do not instantiate splitters needlessly

The two splitters can be easily shared -- so do that instead of
instantiating them.

Change-Id: I350611fb5985b4336018562012526ca1910bb9a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1611: drop a FIXME for thread-safety

Caching a module means the class is not safe for use from multiple
threads.

Change-Id: Id60447efe4dbae4b65748b99870bd75b70b6fcc8
Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1611: use CharMatcher to remove characters

Instead of compiling the patterns, use a CharMatcher, which is much
faster.

Change-Id: I2d3753824c63d3dece7af6f051f09c644cfdbf34
Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1611: make verbose comments optional

Make sure the yang snippets are completely optional. The default still
includes them.

Change-Id: Id01393c384add733c42baf6c02a153ef388bb628
Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1611: force maven plugin generating verbose comments

This just makes sure we are explicit about what we are creating.

Change-Id: Ib530560c11e7f529345085eecf43a9f6f2e6d1a6
Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1611: make sure runtime components create short comments

The two instantiations here are performance-critical at runtime, and the
comments in them get discarded. Let us not waste time generating them.

Change-Id: If1e9a7507dac5b07011d3a9bcc75e42fbff340e1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Merge changes If1e9a750,Ib530560c,Id01393c3,I2d375382,Id60447ef,I350611fb,I0dbd80db

* changes:
  BUG-1611: make sure runtime components create short comments
  BUG-1611: force maven plugin generating verbose comments
  BUG-1611: make verbose comments optional
  BUG-1611: use CharMatcher to remove characters
  BUG-1611: drop a FIXME for thread-safety
  BUG-1611: do not instantiate splitters needlessly
  BUG-1611: fix SimpleDateFormat