Wrap look-and-feel in a theme

Creates new Theme classes to control the appearance of charts, series, axes and tables.
OK, fair enough.

From: tpkelly [mailto:notifications@github.com]
Sent: 18 August 2014 12:08
To: ScottLogic/insight
Cc: Nicholas Soper
Subject: Re: [insight] Wrap look-and-feel in a theme (#121)


In src/charts/Chart.js:

> @@ -89,8 +90,6 @@

>                  .attr('class', insight.Constants.AxisLabelClass);

>

>              self.addClipPath();

> -

> -            initialized = true;

No, we always want to set a flag to block entry to the function before starting to do the setup, to prevent infinite loops (if init() calls a method which calls draw() which calls init(), for example).

—
Reply to this email directly or view it on GitHub<https://github.com/ScottLogic/insight/pull/121/files#r16347413>.