Make test mysql connection code less confusing

There are two similar methods used for connecting to MySQL apps, but
their arguments differed in order which made for some confusion. This
makes their argument signatures identical.

Change-Id: I48818e2eadb81944e7369e12d09af9c3394d6b57
Add clearer help kwarg for max_volumes_per_user

Add same wording as comment in trove.conf.sample.

Change-Id: I0ad8ca2dd2d6aaa4b7012c491c4a467b6004e4cb
Closes-Bug: #1274608
Remove copyright and comments from empty files

According to policy change in HACKING:
http://docs.openstack.org/developer/hacking/#openstack-licensing
empty files should no longer contain any comments and copyright notices.

Change-Id: I78b399db314518be917e1c1931f2ee5c3a2ee95a
Closes-Bug: #1262424
Adding override.config.template for percona

After the 'adding configuration group support' patch was merged,
percona instance-create is failing because the TM cannot find
the override.config.template for percona. Adding this template
fixes the problem.

Change-Id: I63404cfa8cd9bd850e4fc7457a3d4bcc2711685c
Closes-Bug: #1277376
Ignore outdated messages sent to conductor

Adds a sent_at field to conductor messages in the manager so that
messages that get out of sync on their way to conductor don't cause
trouble by updating instances or backups with out-of-date information.

Implements: blueprint conductor-ignore-old-messages
Change-Id: If06d2f9c9f993100be66f71274240a59b05b66e3
Adding Incremental Backups

* Adding a config flag to register incremental runners
* Adding InnoBackupExIncremental runner and restore strategy.
* Adding save_metadata and load_metadata methods for
  swift storage strategy.
* Adding incremental backup/restore integration test.

Implements: blueprint incremental-backups

Change-Id: I1f0d4e5967097498f86a5052c33c55471e24a137
Merge "Make test mysql connection code less confusing"
Adding additional datastore tests

This adds 4 more datastore types and versions tests.

Change-Id: I4da3721a764d76e1bd625da69fdef3976edb64d7
Modifying tests to run with different configurations

Updated datastore tests to make datastore configurable and not
assume that 'mysql' datastore will always exist.

Fixed test_create_with_bad_availability_zone. Before it was
giving a false positive. Now it is testing the right thing.

Change-Id: Ie4e81e173b73302b40e521e4a41569404203b9d2
Closes-Bug: #1276346
Merge "Ignore outdated messages sent to conductor"
Merge "Adding additional datastore tests"
Improve help strings

Follow oslo.config style guide for help strings better to create
consistent help strings:
* Capitalize first word of each help string
* Finish help strings with "."
* Improve wording and capitalization

Change-Id: I461589e4d20be6085281962ebf6e99262a58c761
Merge "Modifying tests to run with different configurations"
Remove unused admin_context from conductor manager

This variable was used nowhere, plus it referenced three config
variables which were also in the sample config file that Conductor
doesn't need.

Change-Id: I08ffe578158c73d387112b6c05b7ab2c6cae833b
Corrects service URLs from "%s/%s/" to "%s/%s"

Reasons:
- "%s/%s/" adds extra / making it "//" whenever it goes to the resources
  like nova or heat or cinder.
- Though it was working fine for nova and cinder, but following recent
  changes on heat/heat-client this is giving an error:
  "The resource could not be found.".

Changes:
- Updates the URLs from "%s/%s/" to "%s/%s".

Change-Id: I95b2601c7eaf577eb13590cbb74255ecbd5b9f1d
Closes-Bug: #1271126
Merge "Remove copyright and comments from empty files"
Merge "Corrects service URLs from "%s/%s/" to "%s/%s""
Raises BadRequest for grant_access on ignore_dbs

Reasons:
- Currently, it just logs an informative log in guestagent log, and then
  control shifts to next line, which provides the requested grant.
- This brings the need to raise the exception instead of informative
  logging.

Changes:
- Raises BadRequest if ignore_dbs are requested access instead of
  informative logging into guest-agent logs.

Change-Id: I9df08d04cd42916f3d1f91e05cd4799bb9041eae
Closes-Bug: #1257021
Fixes a race condition in resize flavor

When resizing an instance's flavor, Trove asks the guest to start the
datastore via an RPC call and then, to be safe, would check the
service_status table in the database to make sure it was updated to
RUNNING. The thing is, that second check was not only superfluous, it
was causing resizes to fail in the post-conductor world, because while
the guest would have sent a message to conductor describing the
datastore's current state before it informed taskmanager that it had
finished the call, conductor itself might not have updated the
database. This commit changes things so taskmanager polls until the
service_status is RUNNING after calling the guest. If there is an error
the call to the guest will fail anyway.

Change-Id: I4e1ca75a150ed58233c21372d21c6337596e43d0
Closes-Bug: 1278282
fix traceback when default_version is not in the database

This commit lets the right error be raised which ends up in the cli as
e.g:

Datastore version '5.5' cannot be found.

Change-Id: I636bf43d135b2143f2a3bd1878215d7ec270330e
Closes-Bug: #1278965