commit s1 assignment2