+1

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Jan 16, 2014 8:19 PM, "Roberto Segura" <notifications@github.com> wrote:

> In libraries/joomla/updater/adapters/extension.php:
>
> >  					if (isset($this->latest))
> >  					{
> > -						if (version_compare($this->currentUpdate ->version, $this->latest->version, '>') == 1)
> > +						// Check if PHP version supported via <php_minimum> tag, assume true if tag isn't present
> > +						if (!isset($this->currentUpdate->php_minimum) || version_compare(PHP_VERSION, $this->currentUpdate->php_minimum, '>='))
> > +						{
> > +							unset($this->currentUpdate->php_minimum);
> > +
> > +							$phpMatch = true;
> > +						}
> > +						else
> > +						{
>
> Can we add here something like:
>
> JFactory::getApplication()->enqueueMessage(
>     $this->currentUpdate->name . ' available version ' . $this->currentUpdate->version . ' requires PHP version: '
>     . $this->currentUpdate->php_minimum. '. Installed PHP version: ' . PHP_VERSION,
>     'warning');
>
> This way users will notice that there is a new extension version that
> requires newer PHP_VERSION
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/joomla/joomla-cms/pull/2802/files#r8954691>
> .
>