added doc params and return values