Avoid PHP notices when building is_new clause in BP_Notifications_Notification::get()

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8171 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Return false friends_add_friend() when the initiator is the same as the friend

It's good to love yourself, but there's no real reason to allow
self-friendships in BuddyPress.

See #5319

Props megainfo, r-a-y

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8172 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Fix check for existing friendship in friends_add_friend()

The previous logic would always result in this check failing.

Fixes #5319

Props r-a-y

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8173 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Enable Spam admin tools on non-MS users.php Dashboard panel

This change brings non-MS installations of BuddyPress closer to the
functionality that is native to WP Multisite, with respect to the ability to
manage spam/ham users from the Users panel. It also addresses a shortcoming
whereby admins on non-MS sites would have no way at all to spam/unspam users
if the Settings component was disabled, since the front-end Spam tools are in
that optional component.

Fixes #5113

Props imath, r-a-y

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8174 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Don't allow a user to favorite a single activity item more than once.

Fixes #5478

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8175 cdf35c40-ae34-48e0-9cc9-0c9da1808c22