edit question func is improved