fix some garbage / never used values, add infinity

clang --analyze brings up these warnings
that's true, I agree. Can you just do it like this ?

On 25 November 2014 at 10:23, Luigi Ballabio <notifications@github.com>
wrote:

> In QuantLib/ql/qldefines.hpp:
>
> > @@ -141,6 +141,10 @@
> >  #define QL_MAX_REAL            ((std::numeric_limits<QL_REAL>::max)())
> >  #define QL_MIN_POSITIVE_REAL   ((std::numeric_limits<QL_REAL>::min)())
> >  #define QL_EPSILON             ((std::numeric_limits<QL_REAL>::epsilon)())
> > +#define QL_INFINITY                                                            \
> > +    ((std::numeric_limits<QL_REAL>::has_infinity                               \
> > +          ? std::numeric_limits<QL_REAL>::infinity()                           \
> > +          : QL_MAX_REAL))
>
> I'm not sure about this macro. If we call it QL_INFINITY, there are
> expectations about it (e.g., that infinity/2 is still infinity) that are
> not met by QL_MAX_REAL. Instead, I would use QL_MAX_REAL explicitly in
> BinomialDistribution.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lballabio/quantlib/pull/173/files#r20850826>.
>