New code should use the two-pool paradigm pool names.  So, let's do it
for the index.* functions that don't do it yet, have only a single POOL,
shouldn't have two and don't have the signature defined by the cache
interface.

IOW, just rename a bunch of pool parameters and update the doc strings
accordingly.

* subversion/libsvn_fs_fs/index.h
  (svn_fs_fs__l2p_proto_index_open): The POOL is the RESULT_POOL. 
  (svn_fs_fs__l2p_proto_index_add_revision,
   svn_fs_fs__l2p_proto_index_add_entry,
   svn_fs_fs__l2p_index_append): The POOL is a SCRATCH_POOL; there is no
                                 result to be allocated.
  (svn_fs_fs__p2l_proto_index_open): The POOL is the RESULT_POOL. 
  (svn_fs_fs__p2l_proto_index_add_entry,
   svn_fs_fs__p2l_proto_index_next_offset,
   svn_fs_fs__p2l_index_append,
   svn_fs_fs__p2l_entry_lookup,
   svn_fs_fs__item_offset,
   svn_fs_fs__p2l_get_max_offset): The POOL is a SCRATCH_POOL; there is
                                   no result to be allocated.

* subversion/libsvn_fs_fs/index.c
  (packed_stream_open): The POOL is the RESULT_POOL.
  (write_entry_to_proto_index,
   encode_l2p_page): The POOL is a SCRATCH_POOL.
  (svn_fs_fs__l2p_proto_index_open,
   svn_fs_fs__l2p_proto_index_add_revision,
   svn_fs_fs__l2p_proto_index_add_entry,
   svn_fs_fs__l2p_index_append): Mirror header / API changes.
  (get_l2p_page_info,
   get_l2p_page_table): The result is a pre-allocated struct.
                        The POOL is just a SCRATCH_POOL.
  (get_l2p_page): The only allocations done here are for the result.
  (l2p_index_lookup,
   l2p_proto_index_lookup): The result is pre-allocated.
                            The POOL is just a SCRATCH_POOL.
  (get_l2p_header): All allocations are for the result.
  (svn_fs_fs__item_offset,
   svn_fs_fs__p2l_proto_index_open,
   svn_fs_fs__p2l_proto_index_add_entry,
   svn_fs_fs__p2l_proto_index_next_offset,
   svn_fs_fs__p2l_index_append): Mirror header / API changes.
  (get_p2l_page_info): The result is a pre-allocated struct.
                       The POOL is just a SCRATCH_POOL.
  (get_p2l_page): All allocations are for the result.
  (get_p2l_keys,
   p2l_get_max_offset): The result is pre-allocated.
                        The POOL is just a SCRATCH_POOL.
  (svn_fs_fs__p2l_get_max_offset): Mirror header / API change.
  (calc_fnv1): The result is written to a pre-allocated struct.
               The POOL is just a SCRATCH_POOL.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1626871 13f79535-47bb-0310-9956-ffa450edef68