basic tests have been done. We can add more tests in our specs