utility to combine PaymentTransactionInfoPlugins

Maybe the pull request can be simplified to hide internal changes that aren't interesting after the fact
Maybe I'm confused. It won't exist immediately after
doing Killbill::Plugin::Model::PaymentTransactionInfoPlugin.new (I think).
Are you saying that I should assume that PaymentTransactionInfoPlugin is
being used properly and all uses will set properties? (this is reasonable
but I want to make sure that I understand).

-Kevin


On Fri, Aug 15, 2014 at 3:03 AM, Pierre-Alexandre Meyer <
notifications@github.com> wrote:

> In lib/killbill/helpers/utils.rb:
>
> > +        t3.gateway_error_code=t1.gateway_error_code
> > +        t3.first_payment_reference_id=t1.first_payment_reference_id
> > +        t3.second_payment_reference_id=t1.second_payment_
> reference_id
> > +        t3.test1=t1.status
> > +        t3.test2=t1.status== :PROCESSED && ( t2.nil? || t2.status== :PROCESSED)
> > +
> > +        # Now we need to combine the properties for the two objects. When we combine objects, we need to make sure
> > +        # that we don't lose any information so the first time an object is combined with others its values need to
> > +        # be stored as properties and we add a transaction_count property. Subsequently, when we combine such objects
> > +        # we need to renumber the property keys to maintain uniqueness and update the transaction_count
> > +
> > +        t3.properties=[]
> > +
> > +        # Find the transaction count for t1 if it exists and clone the properties from t1 into t3
> > +        t1_trx_count=nil
> > +        unless defined?(t1.properties)==nil || t1.properties.nil?
>
> Why defined?? It should always exist.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/killbill/killbill-plugin-framework-ruby/pull/4/files#r16286454>
> .
>



-- 
Kevin Postlewaite