add doc of traits