About the tests, there are 2 reasons why i didn't create them:
- There is no clear criteria on what should be tested. I see some unit tests, but in most of the cases there are no tests, or at least the test naming convention doesn't make it possible to easily see if there are tests. We should have this clarified (what should and what should not have tests)
-I could create a unit test for this class, and actually i like to create them using mocks. But this would not be the simplest test, as i would need to prepare several expectations on the metadata xml, or rely on a real database (integration test?)

If having tests or not is a relevant concern for pull-request/code reviews, maybe we should have an easy/automated way to check it, using code coverage tools (with fine tuned settings for our needs), maybe running on some quality build