I don't think that it does any of that actually - all it seems to do is get articles (or content? Which name makes more sense?) from somewhere. This is a concrete class, and its accessing things remotely (as opposed from a DB, or a cache, or whatever).

What's the name of the service it hits? Is it the public website itself? Maybe we should name it after that? PublicWebsiteContentRepository?, PublicWebsiteArticleRepository?

(Although maybe including the word repository seems a little redundant given that it's in a Repositories module already?)

Or am I totally misunderstanding what this class is for?


----------------------------
Sent from my phone

> On 12 Feb 2014, at 21:40, Pablo Manrubia <notifications@github.com> wrote:
> 
> In lib/core/repositories/api.rb:
> 
> > @@ -0,0 +1,42 @@
> > +require 'faraday'
> > +require 'faraday/request/request_id'
> > +require 'forwardable'
> > +
> > +module Core
> > +  module Repositories
> > +    class API
> Man!, if you want to describe what it does... this is a connector / adapter to a REST service which can be used with repositories, Single Sing ON Servers, CRM... following MAS convention (with request IDs for tracking purposes)
> 
> Core::Repositories::RemoteContentService means nothing to me. You don't really know what the object does reading its name (bad smell for me). We have 6 words that describes almost nothing and everything at the same time.
> 
> In fact, this is not a Service, but a way to connect to a Service, which is a very different thing.
> 
> This is a piece os software that will be used to connect to remote services.
> 
> —
> Reply to this email directly or view it on GitHub.