I think we should keep kvec changes at minimum. `a`, `n` and `m` aren't
that bad. Would be good variable names in a mathematical proof dealing with
arrays. An array `a` of size `n` and capacity `m`.
On May 29, 2014 7:12 PM, "Justin M. Keyes" <notifications@github.com> wrote:

> In src/nvim/lib/kvec.h:
>
> > @@ -53,39 +53,39 @@ int main() {
> >
> >  #define kv_roundup32(x) (--(x), (x)|=(x)>>1, (x)|=(x)>>2, (x)|=(x)>>4, (x)|=(x)>>8, (x)|=(x)>>16, ++(x))
> >
> > -#define kvec_t(type) struct { size_t n, m; type *a; }
> > -#define kv_init(v) ((v).n = (v).m = 0, (v).a = 0)
> > -#define kv_destroy(v) free((v).a)
> > -#define kv_A(v, i) ((v).a[(i)])
> > -#define kv_pop(v) ((v).a[--(v).n])
> > -#define kv_size(v) ((v).n)
> > -#define kv_max(v) ((v).m)
> > +#define kvec_t(type) struct { size_t size, capacity; type *items; }
> > +#define kv_init(v) ((v).size = (v).capacity = 0, (v).items = 0)
> > +#define kv_destroy(v) free((v).items)
> > +#define kv_A(v, i) ((v).items[(i)])
> > +#define kv_pop(v) ((v).items[--(v).size])
> > +#define kv_size(v) ((v).size)
> > +#define kv_max(v) ((v).capacity)
>
> We should fork the klib tests
> <https://github.com/attractivechaos/klib/tree/master/test> if we are
> going to fork klib. Could be another entry-level item.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/neovim/neovim/pull/781/files#r13208009>.
>