work on encoders