I'm not a fan of one line if statements, I think they are often difficult to read. Ruby style guide doesn't enforce them from my understanding but happy for you to modify :)