(maint) Enable rubocop checking for shadowed variables

Previously, we allowed variables to be shadowed by variables
of the same name at local scope. This can make for confusing
reading to someone new to the code (and can potentially indicate
logic errors).

So this commit enables rubocop checking for shadow variables. It
also fixes (by renaming) all extant shadowed variables. Naming
is hard, but a best effort was made.
Good point, that does look odd. I went through some of the git history to see if the `.tap` was orphaned from earlier usage but didn't find it. There's one in `lib/puppet/modules.rb`'s `load_metadata` method that might be a cleanup possibility too.