Sorry I don't have better answers to some of the line notes. Some of this
code was written as long as 6 months ago, so I don't remember exactly what
I was thinking at the time. I'll try to look into some the your questions
more deeply this weekend.


On Thu, Apr 17, 2014 at 10:17 PM, Brent Yorgey <notifications@github.com>wrote:

> In src/Diagrams/TwoD/Attributes.hs:
>
> > +
> > +-- | A synonym for 'fillColor', specialized to @'Colour' Double@
> > +--   (i.e. opaque colors). See comment after 'fillColor' about backends.
> > +fc :: (HasStyle a, V a ~ R2) => Colour Double -> a -> a
> > +fc = fillColor
> > +
> > +-- | A synonym for 'fillColor', specialized to @'AlphaColour' Double@
> > +--   (i.e. colors with transparency). See comment after 'fillColor' about backends.
> > +fcA :: (HasStyle a, V a ~ R2) => AlphaColour Double -> a -> a
> > +fcA = fillColor
> > +------------------------------------------------------------
> > +
> > +data FillLoops v = FillLoops
> > +
> > +instance Typeable v => SplitAttribute (FillLoops v) where
> > +  type AttrType (FillLoops v) = FillColor
>
> Ugh, I think this now needs to consider both FillColor *and* FillTexture,
> but the way I have it set up it can only handle doing one at a time. =(
>
> One solution I suppose would be to make a second function akin to
> splitFills but acting on FillTexture. It's just a bit annoying to have to
> do two passes, but it should only be a few extra lines of code (copy lines
> 551-566 here and change a few things).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/diagrams/diagrams-lib/pull/136/files#r11762174>
> .
>