core: UpdateVmDiskCommand - compare enums with ==

Use == to compare enums instead of equals(Object), as per the project's
conventions.

Change-Id: Idc5eea69db33ad4a0431f1123df2594c434d506c
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: UpdateVmDiskCommand diamond generics

Use Java 7 style diamond generics for better readability.

Change-Id: I0a14bbece3f0b5487e06b5946493cbc819ea5b0c
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: UpdateVmDiskCommand singletonList

Use the better performing Collections.singletonList instead of
Arrays.asList.

Change-Id: I68f3a676fe51317499783d0f62239069574ae1f2
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: rm UpdateVmDiskCommand unused methods

Removed UpdateVmDiskCommand#getVmsDiskSnapshotPluggedTo(), which is
not used anywhere in the codebase.

Change-Id: I7228911b3184858323bd934f1fd890ca6c9fdb21
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Rename UpdateVmDiskCommand CDA methods

Renamed shouldUpdate*Properties() methods to
update*RuntimeParametersRequested() which better reflects what these
methods do - they check if an update to a certain parameter was
requested, they do not decide if it's appropriate (as the "should"
prefix would suggest).

Change-Id: I91789866212b88e39b2e133c2d29c57475a7a624
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Allow updating wipeAfterDelete for an UP VM

The wipeAfterDelete property simply determines how the VM's volumes
should be treated when they are deleted, and has no effect on how the VM
is run.
There is no reason to disallow updating them when the VM is running.

Change-Id: I8fcb93ab0e45798745e2e5accc2d851b6df00d6d
Bug-Url: http://bugzilla.redhat.com/1070823
Signed-off-by: Allon Mureinik <amureini@redhat.com>