Fix --walltime parsing for sub_test

When passing --walltime to the executable (for slurm and pbs) the string we
created was only valid for times under 100 minutes. After that it became
invalid. We never run into this in nightly testing, but I ran into it when
trying to see how long hpl release would take to finish for gasnet+mpi
Update pbs-aprun launcher to use place/select for pbspro

The mpp* options have been deprecated (but still functional) for a while. Many
systems are completely disabling the mpp* options so we need to adjust to use
the place/select options for pbspro. For moab/torque we already used a different
set of options to request resources.
Fix primitive query formals bug

Prior to this commit, `proc f(x:int(?a), y:int(?b)) {}` would crash the
compiler on the fn->defPoint->insertAfter call in
clone_for_parameterized_primitive_formals.

The `fixup_query_formals(newfn)` call was redundant. newfn is added to
gFnSymbols on creation, so fixup_query_formals will be called on it in
the loop over gFnSymbols in normalize() (line 122).

If fixup_query_formals is called twice on a FnSymbol with primitive
query formals, the second call will fail, because the first call results
in the FnSymbol's defPoint being removed from its parent list.
Remove primitive query formals bug from STATUS
Enabled simple-alias-mem-use.chpl under gasnet.
Skip anonymous iter optimization test for llvm

Mike pointed out that this test started failing for llvm. It's a test that
essentially greps the generated code to make sure the optimization fired. It's
greping the c code, so it needs to be skipped for llvm.
Merge pull request #1061 from ronawho/elim-anonymous-range-construction

Skip anonymous iter optimization test for llvm

Mike pointed out that this test started failing for llvm. It's a test that
essentially greps the generated code to make sure the optimization fired. It's
greping the c code, so it needs to be skipped for llvm.
Merge pull request #1045 from ronawho/fix-sub-test-walltime-parsing

Fix --walltime parsing for sub_test

[reviewed by @thomasvandoren]

When passing --walltime to the executable (for slurm and pbs) the string we
created was only valid for times under 100 minutes. After that it became
invalid. We never run into this in nightly testing, but I ran into it when
trying to see how long hpl release would take to finish for gasnet+mpi
Make HPCCProblemSize.notest own file instead of symlink from original location

Making it a symlink was unnecessary laziness on my part, as notests are just
empty files.
Fix skipif to work on --fast (when not a performance run)

I mistakenly made the skipif to make sure these new test copies only ran during
performance testing use an "and" instead of an "or", so that when --fast was
detected but --static was not, the skipif still allowed the test to run.
Merge pull request #1062 from lydia-duncan/resolveSymlinkPerfErrors1

Make HPCCProblemSize.notest own file instead of symlink from original location

Making it a symlink was unnecessary laziness on my part, as notests are just
empty files.
Merge pull request #1063 from lydia-duncan/resolveSymlinkPerfErrors2

Fix skipif to work on --fast (when not a performance run)

I mistakenly made the skipif to make sure these new test copies only ran during
performance testing use an "and" instead of an "or", so that when --fast was
detected but --static was not, the skipif still allowed the test to run.
Merge pull request #1050 from sbillig/fix_primitive_query_formals_bug

Fix multiple primitive query formals bug

[Merged on behalf of Sean Billig.]
Make the symbolic links I used for the new perf suite relative

I had accidentally made these absolute symbolic links, so when they were run
somewhere that didn't have access to my files, errors were generated.

While I was there, I made the spectral norm .perfkeys file its own file instead
of a link from a different location, because that seemed likely to lead to less
surprising behavior in the future.
Merge pull request #1064 from lydia-duncan/resolveSymlinkPerfErrors3

Make the symbolic links I used for the new perf suite relative [ok'd in principle by mike]

I had accidentally made these absolute symbolic links, so when they were run
somewhere that didn't have access to my files, errors were generated.

While I was there, I made the spectral norm .perfkeys file its own file instead
of a link from a different location, because that seemed likely to lead to less
surprising behavior in the future.
Change skipif files (again) for new performance suite.

I had been a little uncertain about using the presence of --fast and --static
to determine if a performance test was occurring, but hadn't seen an environment
variable that would cover it when I looked in start_test for the handling of
-performance.  That's because the environment variable is assigned when the
variable created by the flag (performance) is checked later on.  We really need
to rewrite start_test.  Anyways, switch the skipifs back to non-executable and
check against this environment variable.

Thanks to Elliot for pointing this out.
Add missing space
Merge pull request #1044 from ronawho/fix-pbs-aprun-mpp

Update pbs-aprun launcher to use place/select for pbspro

[reviewed by @thomasvandoren]

The mpp* options have been deprecated (but still functional) for a while. Many
systems are completely disabling the mpp* options so we need to adjust to use
the place/select options for pbspro. For moab/torque we already used a different
set of options to request resources.
Merge pull request #1065 from lydia-duncan/resolveSymlinkPerfErrors4

Change skipif files (again) for new performance suite. [reviewed by elliot]

I had been a little uncertain about using the presence of --fast and --static
to determine if a performance test was occurring, but hadn't seen an environment
variable that would cover it when I looked in start_test for the handling of
-performance. That's because the environment variable is assigned when the
variable created by the flag (performance) is checked later on. We really need
to rewrite start_test. Anyways, switch the skipifs back to non-executable and
check against this environment variable.

Thanks to Elliot for pointing this out.
Merge pull request #1060 from vasslitvinov/enable--simple-alias-mem-use.chpl--under-gasnet

Enabled simple-alias-mem-use.chpl under gasnet.

This test:
  test/distributions/robust/arithmetic/reindexing/simple-alias-mem-use.chpl
used to fail intermittently under gasnet.

The failure was represented by
  test/memory/vass/crash-memory-module-1.chpl
which was handled in r22223 aka 7209b2d a year ago.

Let's enable  simple-alias-mem-use.chpl  under gasnet and see if it succeeds there consistently.

Discussed with Mike.