Replication

@enisoc @aaijazi 
More clarifications here

The source had:
Generate(cursor VCursor, keyspace_id key.KeyspaceId) (id int64, err error)

The golint problem here is keyspace_id has the underscore, so I tried to
solve that. First version was keyspaceID, but then I realized the variable
names were useless, so I just removed them. Naming variables makes sense is
the name is useful.

For the rest, we had:
func (_ *XXX) fffff...
the underscore is not good, I replaced it with a real name, I agree it
needs to be replaced with nothing at all, and that will probably work...
Will make that change.


Make sense?


On Thu, Dec 18, 2014 at 3:46 PM, sougou <notifications@github.com> wrote:

> In go/vt/vtgate/planbuilder/plan_test.go
> <https://github.com/youtube/vitess/pull/260#discussion-diff-22080795>:
>
> > @@ -23,41 +23,41 @@ import (
> >  // hashIndex satisfies Functional, Unique.
> >  type hashIndex struct{}
> >
> > -func (_ *hashIndex) Cost() int { return 1 }
> > -func (_ *hashIndex) Verify(_ VCursor, _ interface{}, _ key.KeyspaceId) (bool, error) {
> > +func (hi *hashIndex) Cost() int { return 1 }
>
> That sounds like a good idea, if lint accepts it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/youtube/vitess/pull/260/files#r22080795>.
>