drop out of date undef SfxTabDialog foo

Change-Id: I01d31d357f503ca32b18f3414305ca5dcf55f9ce
untangle the bFmt == 2 hack

Firstly, IsFormat is unused so there's no "escape" of
bFmt back into the outside world.

Then bFmt has two purposes.

Purpose 1 is 'not be a format dialog, be a format dialog, be a format dialog but hide standard button'

so, lets just add an explicit "Hide standard button" method and call
it in the (apparently) one place where it's necessary.

Purpose 2 is to flag that "BaseFmtHdl" was called from clicking
the "Standard" button at which point its set to 2.

SfxTabDialog::Init_Impl had...

"
  // bFmt = temporary Flag passed on in the Constructor(),
  // if bFmt == 2, then also sal_True,
  // additional suppression of the standard button,
  // after the Initializing set to sal_True again
  if ( bFmtFlag != 2 )
      m_pBaseFmtBtn->Show();
  else
      bFmtFlag = sal_True;
"

but the variable acted on is bFmtFlag a copy of bFmt, and is never read again
after that line, so setting it to sal_True is meaningless. The comment suggests
that the intent is to reset bFmt to true if it was 2 during initialization,
which fits with the later use of bFmt == 2 to indicate that the standard button was
clicked, i.e. reset bFmt back to its standard value.

So make bFmt a simple toggle of dialog as a format dialog or not, add a way
to remove the standard button and add a second variable to indicate the standard
button got pressed.

Change-Id: I98a441f5f314845abe243e05b6d92fd71d7b0b04
coverity#708117 Uninitialized scalar field

Change-Id: I7ef430d48c7a984bc68f89fdcca821ddd2265853
coverity#708119 Uninitialized scalar field

Change-Id: I746a90d5af339fc0dc7471e1e7fed88e6933b50e
coverity#708120 Uninitialized scalar field

Change-Id: I097d0bc2df695df0e3d170efc0bee39f8b00a954
WaE: -Werror=uninitialized

Change-Id: I6cda8d722299df581326ad4c7391609a480bd39f
coverity#708121 Uninitialized scalar field

Change-Id: I73d128c82281f252af62f0318dd1d15e11c0e9a7
coverity#708123 Uninitialized scalar field

Change-Id: I3161342b7033e376ef3fb49ffd63b4577ef18811
coverity#708124 Uninitialized scalar field

Change-Id: Id5cb00b710a91c63eff40025b6c91a985ea90ad7
coverity#708126 Uninitialized scalar field

Change-Id: Ib5dfaaf60551ed87c650863388e2e81b899bd253
coverity#708128 Uninitialized scalar field

Change-Id: Ic22b6640ba6b87769bdf00bc630d463de1ba04ad
coverity#708131 Uninitialized scalar field

Change-Id: I95ad784b96a130a7549266ebda883389941cf962
coverity#708132 Uninitialized scalar field

Change-Id: I24496262cc2101e47b83878dc0c7cef963471a5c
coverity#708134 Uninitialized scalar field

Change-Id: Id00f771bb7ba80c60aae5f94050319b26aa2c861
coverity#708137 Uninitialized scalar field

Change-Id: I27966ee56ceac9a82fe901e942540c8e5d9c93dc
coverity#708138 VisualState::SetMouseOverState sets things that noone reads

Change-Id: Ifc78a7c656520b779559362e309f6971ecb1f573
coverity#708141 baseclass mnPageCount is unused

Change-Id: I65be7d072bb8762feaf22158104d58f0c0149f33