fix double-_localstorage_ in Attachment#infer_namespace

test plan:
 - in a Rails development environment using local file storage,
   1. use the content migration API to import the contents
      of a zip file into a folder in a course
      (use zip_file_importer as the migration_type, and set
       settings[folder_id] to the id of a folder in the course)
   2. repeat step (1), but specify a different folder id
   3. confirm the files can be downloaded and/or deleted in the
      second folder without a "Cannot find Account with id=0"
      error

fixes CNVS-15726

Change-Id: Icb73efcf5b933f4a6b9dea9c0e2c884bfb82afd5
Reviewed-on: https://gerrit.instructure.com/41583
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Enchance a11y on dashboard activity feed

Fixes CNVS-14501

Makes the show/hide more and remove options in the dashboard activity
feed show all the time, not just on mouseover, in order to improve
keyboard a11y.

Adds aria-label to the context link informing a screenreader user where
that link is going to go.

Test Plan:

1) Give yourself at least one announcement, conversation message,
   assignment notification, and discussion. Easiest way is to create a
   a course and add an announcement, send a message to yourself from
   another user, add an assignment, and add a discussion.
2) Visit the dashboard (localhost:3000/)
3) Verify that the list of notifications is navigable with the keyboard
   only, because you can see from the get go that the 'show more' option
   and remove/ignore option.
4) Using a screenreader, navigate to the notification heading, then onto
   the course name link. Verify that you hear label text like
   "Visit Course Discussions" or similar. This should help SR users only
   click that option if that's what they want, so they keep looking for
the "Show More" option (it's one link further through the tab flow) if
that's what they want instead.

Change-Id: I0726510a351f16768d98657e9891cb7a1c162be3
Reviewed-on: https://gerrit.instructure.com/41417
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fix embedded modal content heights, fixes CNVS-15700

this broke in a recent css/layout refactor

test plan:
1. allow self enrollment on a course, and the join course button
2. as an unenrolled student, click the button
3. the modal should appear and its footer should be at the bottom

Change-Id: I7c33bbae72674b7586b5fb7dda2e61835f7b0754
Reviewed-on: https://gerrit.instructure.com/41471
Reviewed-by: Jeff Belser <jbelser@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
DRY up react propTypes in newfiles

I did this to see if we could remove some of the 
duplicate logic and make it easier to enforce
that we are getting the right propTypes in
stuff in newFiles. I'm interested in your feedback
if you like this more or less.

Change-Id: I6e5093ba68889d15352eb59ed8016e25dbdc526b
Reviewed-on: https://gerrit.instructure.com/41631
Reviewed-by: Dan Minkevitch <dminkevitch@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
don't build_assignment on quizzes when importing

test plan:
* copy a course with an unpublished quiz (also try
while adjusting or removing dates)
* should not create "quiz-less" assignments that
 break the assignments page

fixes #CNVS-15477

Change-Id: Ib7d39735936956ea77cc555aeafdcacec2cccfcf
Reviewed-on: https://gerrit.instructure.com/41445
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
s/ActionController/ActionDispatch/

Change-Id: I4b4cab7e8cf1228e19bbdc4bcfe1059dc2f4265d
Reviewed-on: https://gerrit.instructure.com/41627
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
DA - let students see old submissions

CNVS-15685

test plan:
  - DA ON:
    - make a differentiated assignment and assign to student
    - as student, turn in a submission
    - as teacher, take a way visibility
    - as student, use a direct link to get to yoru assignment
      - you should be able to see it and get a flash notification
  - DA OFF:
    - you can also see the submission but get no notification

Change-Id: I01cebc5d2a12ed769496d6f61a2a81adedd74241
Reviewed-on: https://gerrit.instructure.com/41443
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
pin node-sass at 0.9.3

the newer version we were using (0.9.5-rc1) seems to have a bug
that causes it to drop 'left' and 'right' styles

test plan:
 - the 'HTML Editor' and 'Rich Content Editor' links on the wiki
   page editor should appear on the right side and should not
   overlap the page title

fixes CNVS-15760

Change-Id: Icab9be6b25114485f0f5d9990b1eb3c1d600b35f
Reviewed-on: https://gerrit.instructure.com/41720
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fix issue with infinite loop existing a partially completed quiz

fixes CNVS-11763

test plan:
  - login as a user
  - take a quiz in Chrome
  - while taking the quiz in, press 'backspace' or 'delete' twice quickly
  - prompt 'are you sure you want to leave this page?' appears
  - you should be able to dismiss the prompt and remain on the page

  - other things to check
  - trying to leave multiple times will continue to show the prompt every time
  - you should be able to successfully leave the page from the prompt

Change-Id: I1e9454ae902e6686f48c48f1c05cf1e28f2d0c39
Reviewed-on: https://gerrit.instructure.com/41457
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
Spelling correction for file_rename_form

fixes CNVS-15751

Change-Id: I8be9b14837aa899b4d80f479b528e4b60dfca19e
Reviewed-on: https://gerrit.instructure.com/41608
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
DA - observer refactor

refs CNVS-15158

test plan:
  - general regression test as observers for selrel
  - things to look at: assignments, quizzes,
    discussions, & module index pages, quizzes api

Change-Id: I1211c58ebbd8bc0cd32610fafad215d11af58e16
Reviewed-on: https://gerrit.instructure.com/41039
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Mike Nomitch <mnomitch@instructure.com>
use proper method for getting unserialized_value of a serialized column

fixes rails 4, where the signature for unserialize is different

Change-Id: I52c5fd9b3d7aaac7a4ccea0d9f40adf674e8732a
Reviewed-on: https://gerrit.instructure.com/41651
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
bump encrypted_cookie_store

now allows booting with rails 4

Change-Id: Ieb006a5fc5e005ce8fadc7fd777fc73db927164e
Reviewed-on: https://gerrit.instructure.com/41512
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
New :active and :hover styles on Courses navigation

fixes CNVS-15580

We've listened to some of the feedback from our customers and
have tweaked some of the stylings on the left hand courses nav
to make the active and hover states stand out more.

Test plan:

- Go to a course
- The left side nav should now have a slightly darker background,
and active/hover states should be white background with blue link
- High Contrast setting shouldn't change and will have the dark
background on active and hover with white text; disabled links will
now have a gray background with the dark link

Screenshot of new look: http://cl.ly/image/3f0f412R040X

Change-Id: Ibfd504a6e752d640ddfb351967c2287bcbf9c4a3
Reviewed-on: https://gerrit.instructure.com/41240
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Reviewed-by: Vincent Gonzalez <vgonzalez@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>

Conflicts:
	app/stylesheets/base/_#header.sass
	app/stylesheets/base/_layout.sass
	app/stylesheets/base/_variables.scss
	app/stylesheets/components/_components.scss
Updated es translation

Change-Id: I503366e756f1dee4a3d7aaa85d0bd6d083c1ece3
Updated de translation

Change-Id: Icb9c9db001f90d7dc2238bcf3648734da628cfc6
Updated ru translation

Change-Id: Idc1d0dd1b1a8d45a8aa1da4521d29b8b26953606
Updated fr translation

Change-Id: Ied435953fd3aaee63f635bf714cb5819a1e5dbef
Updated pl translation

Change-Id: I9eb99013839c7ba59f13c5b1a22991c06702f8a2
Updated zh translation

Change-Id: Iba07648c0a426d77ffa32a20dc833ae7c7b749b1