opening and closing
edit values