changes on controller