"Applied fix from trunk for revision: 1561286" 
------------------------------------------------------------------------
r1561286 | jleroux | 2014-01-25 12:58:09 +0100 (sam. 25 janv. 2014) | 6 lignes

A (slightly enhanced) patch from Christian Carlow for "EditEmplPosition form widget missing Internal Org drop down and title incorrect" https://issues.apache.org/jira/browse/OFBIZ-5509

EditEmplPosition shows a partyId field as a text box instead of a <select> drop down that lists the internal orgs.  The field title should also be set to Internal Org instead of PartyId for consistency.

jleroux: while at it I added a tooltip

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1561288 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1561290  " 
------------------------------------------------------------------------
r1561290 | jleroux | 2014-01-25 13:25:04 +0100 (sam. 25 janv. 2014) | 2 lignes

A Christian Carlow's patch for "ListPartySkills displays no results" https://issues.apache.org/jira/browse/OFBIZ-5513

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1561292 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1561305  " 
------------------------------------------------------------------------
r1561305 | jleroux | 2014-01-25 14:35:32 +0100 (sam. 25 janv. 2014) | 4 lignes

A Christian Carlow's patch for "EditEmplPositionReportingStructs LookupEmplPosition associated popup and dropdown empty" https://issues.apache.org/jira/browse/OFBIZ-5510

LookupEmplPosition drop-down and popup window show no results on the EditEmplPositionReportingStructs page for the field.

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1561307 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1561311" 
------------------------------------------------------------------------
r1561311 | jleroux | 2014-01-25 14:49:33 +0100 (sam. 25 janv. 2014) | 2 lignes

A patch from Christian Carlow for "ListReportedToEmplPositionReportingStructs displays no results" https://issues.apache.org/jira/browse/OFBIZ-5512

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1561313 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1561327  " 
------------------------------------------------------------------------
r1561327 | jleroux | 2014-01-25 16:58:00 +0100 (sam. 25 janv. 2014) | 1 ligne

A Christian Carlow's patch for "ProductionRunServices.productionRunTaskReturnMaterial: Unknown parameter found: [productionRunTaskProduce.uomId]" https://issues.apache.org/jira/browse/OFBIZ-5506
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1561329 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1561467  " 
------------------------------------------------------------------------
r1561467 | jleroux | 2014-01-26 10:00:59 +0100 (dim. 26 janv. 2014) | 1 ligne

A fix for https://issues.apache.org/jira/browse/OFBIZ-5516, when adding a product to a category the from date field was not shown as required
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1561469 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1560699" 
------------------------------------------------------------------------
r1560699 | jleroux | 2014-01-23 15:35:20 +0100 (jeu. 23 janv. 2014) | 5 lignes

A patch from Justen Walker for "Missing import in FindGeneric.groovy" https://issues.apache.org/jira/browse/OFBIZ-5504

Revision 1560176 introduces a change to FindGeneric.groovy that extracts some logic into UtilMisc. However, this class is not imported in the file and results in a MissingProperty exception.
This patch adds the import statement which resolves this bug.

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1562106 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1562767  " 
------------------------------------------------------------------------
r1562767 | jleroux | 2014-01-30 11:33:26 +0100 (jeu. 30 janv. 2014) | 3 lignes

Closes https://issues.apache.org/jira/browse/OFBIZ-5521 as not a problem
It was my bad, I was simply stupid on this, reverts r1519245

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1562769 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1563238  " 
------------------------------------------------------------------------
r1563238 | jleroux | 2014-01-31 21:06:42 +0100 (ven. 31 janv. 2014) | 8 lignes

Workaround for "Lookups (layered mode) and dropdown menus overlap" (in BizznessTime Theme) https://issues.apache.org/jira/browse/OFBIZ-5519

A good example is in order creation page, open the customer lookup and then try to close it.

I think we should not fiddle with the theme, there is a faster and easier solution: center all lookups in the screen by default. It will not fix but hide the issue for now. Anyway the awful dropdown menu behaviour must be fixed and i will open another Jira for that.

You may ask why I'm concerned with a theme which is no longer bundled in future releases? It's because some custom projects still use it...

------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1563243 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1563683" 
------------------------------------------------------------------------
r1563683 | jleroux | 2014-02-02 18:48:37 +0100 (dim. 02 févr. 2014) | 5 lignes

A patch from Christian Carlow  for "Mandatory and dependent production run links don't navigate to corresponding production run page when clicked" https://issues.apache.org/jira/browse/OFBIZ-5502

When clicking the links associated with madatory or dependent production runs, the corresponding production run page is not loaded. This means its required to go back to the production run search page and lookup the productionRunId manually. I think the links should load the corresponding production run page when clicked.

This simple patch resolves the problem. The <hyperlink> elements in the form widget needed the "link-type" attribute set to "anchor" otherwise it defaults to creating a link that submits a form that automatically sets the productionRunId to the current production run workEffortId which causes this issue.
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1563686 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1563958" 
------------------------------------------------------------------------
r1563958 | jleroux | 2014-02-03 16:44:46 +0100 (lun. 03 févr. 2014) | 3 lignes

Closes "Help screens in Manufacturing" https://issues.apache.org/jira/browse/OFBIZ-4802

This simply follows "HELP_OFBizDocumentationSystem.xml" i18n directives which have been overlooked so far. Of course having all i18n files in the same folder is not very convenient, but at least it works. This files organisation could be reconsidered, I'd need more work...
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1563963 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1564111" 
------------------------------------------------------------------------
r1564111 | jleroux | 2014-02-03 23:29:40 +0100 (lun. 03 févr. 2014) | 12 lignes

A (slightly modified) patch from  Ritu Raj Lakhera for "Order return is not refunding the money" https://issues.apache.org/jira/browse/OFBIZ-5528

When we placed an order with two items and generate a return towards one item then code is refunding the money correctly.
But if we again do return for second item then code is not refunding the money because first return-refund process has changed the status of OrderPaymentPreference from 'PAYMENT_SETTLED' to ‘PAYMENT_REFUNDED’.
I think We should create the new OrderPaymentPreference with PAYMENT_REFUNDED status against old OrderPaymentPreference of 'PAYMENT_SETTLED' status at the time of return-refund process. So second return can also refund the money.

In other words we should create the new OrderPaymentPreference for each refund amount as we are doing with Payment entity(processRefundResult PaymentGatewayServices.java).

jleroux: I 
* replaced the deprecated findByPrimaryKey by a finByOne
* replaced Exception GenericServiceException in catch (as it was before)
* reformatted some parts 
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564115 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1564113" 
------------------------------------------------------------------------
r1564113 | jleroux | 2014-02-03 23:33:09 +0100 (lun. 03 févr. 2014) | 2 lignes

When I replaced the deprecated findByPrimaryKey by a finByOne I forgot to put a catch around, this fixes it.
Also removed an useless logError, ServiceUtil.returnError will take care of it
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564118 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1559814" 
------------------------------------------------------------------------
r1559814 | jleroux | 2014-01-20 20:38:45 +0100 (lun. 20 janv. 2014) | 38 lignes

A patch from Michael Ende for "SimpleMethod parameters doesnt work with prefix" https://issues.apache.org/jira/browse/OFBIZ-5371

I experienced some problems when a form submitted parameters with prefix directly to a SimpleMethod (through the controller request). 
In this case the prefix is not stripped from the parameter name. The patch updates the method ModelService.java:makePrefixMap().

The idea of the prefixMap is: 
If you have some fields like packageweight_1(value=55), packageweight_2(value=65) ... in a form and in a service you need a map called packageweight with the following key values 

packageweight{1=55;2=56;...}

The Problem is that the function makePrefixMap doesn't replace the Prefix.

For Example:
On the "Complete" button of the Facility->Shipment screen we call an event and not the completePack service directly.
The event checks some user rights and after that he call the completePack service. If we call the service from an event there throws an NumberFormatException because the packeweight-PrefixMap contains the prefixes.

This is my event description:
 <simple-method method-name="completePackCheckPermission"
        short-description="Check if this user has permission to create a picklist role"
        login-required="true">
        <check-permission permission="LOGISTICS_CREATE">
            <alt-permission permission="LOGISTICS_ADMIN"/>
            <fail-property resource="EcommerceLogisticsErrorUiLabels" property="NoPermissionForUsage" />
        </check-permission>
        <check-errors />

        <session-to-field field="packingSession"/>
        <set field="parameters.packingSession" from-field="packingSession"/>

        <set-service-fields service-name="completePack" to-map="serviceParameters"
            map="parameters" />
        <call-service service-name="completePack" in-map-name="serviceParameters" />
        <return />
    </simple-method>

jleroux: I'm not quite sure there are no side-effects, but I was not able to find one. So I will wait some time before backporting...


------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564406 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1564463" 
------------------------------------------------------------------------
r1564463 | jleroux | 2014-02-04 21:24:14 +0100 (mar. 04 févr. 2014) | 1 ligne

Update commons-fileupload to 1.3
------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564526 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1564473" 
------------------------------------------------------------------------
r1564473 | jleroux | 2014-02-04 21:36:34 +0100 (mar. 04 févr. 2014) | 1 ligne

Updates geronimo-connector & geronimo-transaction to 3.1.1
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564531 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1564493" 
------------------------------------------------------------------------
r1564493 | jleroux | 2014-02-04 22:09:43 +0100 (mar. 04 févr. 2014) | 1 ligne

Updates geronimo-saaj to _1.3_spec-1.1
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564535 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1564543" 
------------------------------------------------------------------------
r1564543 | jleroux | 2014-02-04 23:41:27 +0100 (mar. 04 févr. 2014) | 2 lignes

Updates axis2-kernel, axis2-transport-http & axis2-transport-local to 1.6.2

------------------------------------------------------------------------
?\026

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564545 13f79535-47bb-0310-9956-ffa450edef68
Reverts 1564545, SOAP tests fail with axis2 1.6.2, keep 1.5.2

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564663 13f79535-47bb-0310-9956-ffa450edef68
"Applied fix from trunk for revision: 1557409" (changed from 4.4 to 52.1 by hand)
------------------------------------------------------------------------
r1557409 | jleroux | 2014-01-11 15:52:23 +0100 (sam. 11 janv. 2014) | 2 lignes

Updates icu4j-49_1.jar to icu4j-52_1.jar (tests passes)

------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/branches/release12.04@1564776 13f79535-47bb-0310-9956-ffa450edef68