COMP: Error due to imporoper linkage specification

inline functions are required to be declared and defined
in the same scope.  The inline specifier changed the linkage
signature an prevented this from compiling.

Undefined symbols for architecture x86_64:
  "vtkMRMLSliceNode::GetNumberOfThreeDViewIDs() const", referenced from:
      PyvtkMRMLSliceNode_GetNumberOfThreeDViewIDs(_object*, _object*) in vtkMRMLSliceNodePython.cxx.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23020 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: Remove end of line spaces

Spaces at the end of lines can cause noise in patch sets
when editors or git gobbles them up during other relatively
minor changes to files.

Removing end of line changes makes long term maintenance easier as
well.

When reviewing git histories or patch sets, the "--ignore-space-change"
option can be useful in filtering out changes due only to spacing.

i.e.
git diff HEAD~2 --ignore-space-change

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23021 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: Githook warnings about excessive line length

pre-commit hook failure
-----------------------
  in file 'Libs/MRML/Logic/vtkImageLinearReslice.cxx' is longer than 160 characters.
  in file 'Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsNode.cxx' is longer than 160 characters.
  in file 'Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsStorageNode.cxx' is longer than 160 characters.
  in file 'Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationControlPointsNodeTest1.cxx' is longer than 160 characters.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23022 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Remove incorrect initialization

A compiler warning indicated incorrect initialization of
minimum value.

Slicer/Modules/CLI/RobustStatisticsSegmenter/SFLSRobustStatSegmentor3DLabelMap_single.h:133:
Slicer/Modules/CLI/RobustStatisticsSegmenter/SFLSRobustStatSegmentor3DLabelMap_single.txx:874:30: warning: implicit conversion
      from 'type' (aka 'unsigned int') to 'short' changes value from 4294967295 to -1 [-Wconstant-conversion]
  m_inputImageIntensityMin = std::numeric_limits<unsigned>::max(); // yes, it's twisted so easity to compute.

The numeric_limits type needed to be made consistent with the image.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23023 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Update SimpleITK 0.8.0 release

The manual download of distribute has been removed. The new
ez_setup.py file can fulfill the setuptools requirement.
SimpleITK's setup.py file can now utilize PowerShell, curl and wget to
download the required setuptools package of https.

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23024 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Test data was missing since Slicer4 (test was still pointing where data
 was in Slicer3)

See bug report:
http://na-mic.org/Mantis/view.php?id=3341

The test that was not working does the following:
It runs ResampleDTIVolume and the result of this operation does not matter.
What is interesting is that the test makes sure that extending itkTestMainExtend
ed.h to work with DTI did not break the normal behavior of that file and that it
 still works with scalar images too.
Therefore, it compares a scalar image with itself and verifies that the test
 passes successfully

From: fbudin69500 <fbudin@unc.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23025 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Remove unused Texture and NCI volume rendering mappers

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23026 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Editor updates Volume Rendering when a new label is added

Closes #3076

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23027 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Accept qMRMLSceneModel::updateNodeItems with node with no scene

To have no scene in qMRMLSceneModel::updateNodeItems()) is a valid case.
When closing the scene, the "Close" state is popped and SceneClosedEvent
event is triggered, caught by an observer that eventually modify a
node, such modification is caught by a scene model that has not yet
received teh SceneClosed event. It asks if the scene is closing but it
is no longer (see vtkMRMLScene::EndState())

Closes #3513

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23028 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Update SlicerExecutionModel

$ git shortlog --no-merges  6956eb..46f3d89
Francois Budin (1):
      Update ModuleDescriptionParser.cxx

Matt McCormick (1):
      BUG: Find JsonCpp library with in a Visual Studio build tree.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23029 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Update windows launcher with Slicer icon.

Thanks to the convenience executable "CTKResEdit" allowing to update
resources of any executables or libraries, on windows, the CTK application
launcher is updated with the Slicer icon.

Fixes #1136

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23030 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: 3609. changed active tensor selector to use QComboBox

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23031 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: 3609. fixed a left over property after conversion to QComboBox

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23032 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix cross-linking to PyGithub documentation

Upstream documentation location for PyGithub has changed; update
intersphinx URL to point to the new location.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23033 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: check validity of node before operating on it

Fixes a crash during scene shutdown.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23034 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Update CTKAppLauncher version to 0.1.12

$ git shortlog v0.1.11..v0.1.12 --no-merges
Jean-Christophe Fillion-Robin (7):
      Begin post-0.1.11 development
      Fix checkout "hang" updating dashboard driver script to use git url
      Upload packages on "http://packages.kitware.com". Fixes #40
      Fix typo in driver script "Additionnal" -> "Additional"
      Download driver script from github
      Better name for Midas packages credential file
      CTKAppLauncher 0.1.12

Matthew Woehlke (24):
      BUG: Fix ctkAppLauncherConfigure dependencies
      BUG: "Fix" creation of launcher executable
      BUG: Don't add '.' to PATH, LD_LIBRARY_PATH, etc.
      STYLE: Refactor platform conditionals
      STYLE: Simplify building path lists
      ENH: Support additional path list envvars
      BUG: Don't add '.' to paths via wrapper script
      STYLE: Make ctkAppLauncherConfigure a function
      ENH: Add --launcher-show-set-environment-commands
      BUG: Fix quoting of environment variables
      STYLE: Avoid gratuitous stack variables
      BUG: Make environment commands actually work
      BUG: Fix problem when no extra paths set
      ENH: Copy CMake helper scripts to build directory
      ENH: Add ctkAppLauncherConfigure test
      ENH: 'Interesting' ctkAppLauncherConfigure tests
      BUG: Resolve test failures
      ENH: Add unit tests for additional paths feature
      BUG: Work around CTest quirk than can break test
      COMP: Fix build against Qt < 4.8
      BUG: Fix unit tests single/multi-configuration
      BUG: Fix App4ConfigureLauncherTest-ConfigureStep
      BUG: Fix TestLauncherVerbose test
      BUG: Correctly fix tests on Windows

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23035 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix/improve launcher path setup

Take advantage of recent changes in the CTK AppLauncher to use the list
form of setting up additional environment path lists. Particularly, we
now declare as path lists those environment variables that are (i.e.
QT_PLUGIN_PATH, PYTHONPATH) so that we no longer lose the user's paths
that have been set in these.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23036 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix creation of launcher configuration

Remove hack to delete the launcher configuration as part of the build.
The launcher CMake helpers should now be producing correct dependency
information such that the hack is unnecessary, and the dependencies for
the hack were not set up correctly, causing ninja builds to fail to
recreate the configuration on alternating runs (which would prevent
slicer from running).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23037 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix/rewrite setupSlicerEnvironment.sh

Rewrite setupSlicerEnvironment.sh to use the new launcher option to
generate commands to set the environment. This fixes several problems
with the old setupSlicerEnvironment.sh, including:

- Failure to properly quote in order to cope with special characters.
- Incorrectly treating everything as a path list.

The new script is a glorified wrapper around 'eval' and exists more for
backwards compatibility than anything (and also now states that it is
deprecated).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23038 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Use correct item_id to download CTKAppLauncher on windows

5295 was the bitstream_id and not the expected item_id.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23039 3bd1e089-480b-0410-8dfb-8563597acbee