common: Remove the code won't be executed

Fixes #942
Closes #944
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: hides empty error box entering realm window

Fixes #935
Closes #939
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Fix blank group list item when adding server.

When adding a server, the group list item won't be genereated
if the address or host name of the machine is empty(whitespace).

Fix handle_add() in the backend to handle empty host name.

Closes #893
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Disables realms-op-auth button

when joining a domain, the realms-op-auth select picker is disabled

Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Displays waiting text and fixes spacing

Displays text to inform the user that the transaction may take a while
and also fixes bug which made the cancel button go above the join button

Fixes #918
Closes #938
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: Hides throbber and text after domain join cancelled

Fixes bug that shows throbber and join message when canceling during
joining a domain. Also exits realm join window when the domain is joined
to get rid of the delay which allowed users to cancel after the domain
was joined.

Reviewed-by: Stef Walter <stefw@redhat.com>
test: glib-networking buildreq added to cockpit.spec

Otherwise the check step fails

Closes #948
Reviewed-by: Stef Walter <stefw@redhat.com>
Release version 0.18
ws: Remove the warning when adding a server with a blank user name

Fixes #941
Closes #958
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: gives user domain admininistrator hint text

After filling in a correct Domain Address, instead of overwriting
the Domain Administrator Name there will be suggested text put
there. This suggested text will put the same values in the text box but in
suggested text form. Furthermore, the text indicates to the user that
it is an example because it might not work for the user's domain.

Fixes #937
Closes #955
Reviewed-by: Stef Walter <stefw@redhat.com>
shell: removes "options" text in join dialog

Fixes #952
Closes #954
Reviewed-by: Stef Walter <stefw@redhat.com>