Eliminate DragSession structure
https://bugs.webkit.org/show_bug.cgi?id=131465

Reviewed by Benjamin Poulain.

Source/WebCore: 

DragSession is really just a transient response to NSDragDestination delegate methods.
The "session" name was quite misleading, and thankfully, we don't need a class for this
bag of data at all.

* WebCore.xcodeproj/project.pbxproj:
* page/DragController.cpp:
(WebCore::DragController::DragController):
(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag):
* page/DragController.h:
(WebCore::DragController::mouseIsOverFileInput):
(WebCore::DragController::numberOfItemsToBeAccepted):
* page/DragSession.h: Removed.

Source/WebKit/mac: 

* WebView/WebView.mm:
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):

Source/WebKit/win: 

* WebView.cpp:
(WebView::DragEnter):
(WebView::DragOver):

Source/WebKit2: 

* Scripts/webkit2/messages.py:
(struct_or_class):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<DragSession>::encode): Deleted.
(IPC::ArgumentCoder<DragSession>::decode): Deleted.
* Shared/WebCoreArgumentCoders.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::didPerformDragControllerAction):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::currentDragOperation):
(WebKit::WebPageProxy::currentDragIsOverFileInput):
(WebKit::WebPageProxy::currentDragNumberOfFilesToBeAccepted):
(WebKit::WebPageProxy::resetCurrentDragInformation):
(WebKit::WebPageProxy::dragSession): Deleted.
(WebKit::WebPageProxy::resetDragSession): Deleted.
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Gtk build fix.

* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LLINT loadisFromInstruction should handle the big endian case.
<https://webkit.org/b/131495>

Reviewed by Mark Hahnenberg.

The LLINT loadisFromInstruction macro aims to load the least significant
32-bit word from the 64-bit bytecode instruction stream and sign extend
it.  For big endian machines, the current implementation would load the
wrong 32-bit word.

Without this fix, the JSC tests will crash on big endian machines.
Thanks to Tomas Popela for diagnosing this issue.

* llint/LowLevelInterpreter.asm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed iOS build fix after http://trac.webkit.org/changeset/167074

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Remove a comment that was incorrectly cut-and-pasted from WidgetBackingStoreCairo
https://bugs.webkit.org/show_bug.cgi?id=131499

Patch by Owen Taylor <otaylor@redhat.com> on 2014-04-10
Reviewed by Martin Robinson.

* platform/gtk/WidgetBackingStoreGtkX11.cpp: Remove a comment that was incorrectly copy and pasted
from the Cairo implementation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Invalid cast in WebCore::RenderLayer::setupClipPath
https://bugs.webkit.org/show_bug.cgi?id=131368

Reviewed by Dirk Schulze.

Source/WebCore:

Only attempt to clip to a box shape if the renderer being clipped is
actually a box.

Test: css3/masking/clip-path-box-shape-on-inline-crash.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupClipPath): Add isBox() check.

LayoutTests:

* css3/masking/clip-path-box-shape-on-inline-crash-expected.txt: Added.
* css3/masking/clip-path-box-shape-on-inline-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Cairo] Implement ShareableBitmap::paint() with scale factor
https://bugs.webkit.org/show_bug.cgi?id=64665

Patch by Owen Taylor <otaylor@redhat.com> on 2014-04-10
Reviewed by Martin Robinson.

* Shared/cairo/ShareableBitmapCairo.cpp (WebKit::ShareableBitmap::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Gtk] run-launcher doesn't work by default
https://bugs.webkit.org/show_bug.cgi?id=131494

Reviewed by Philippe Normand.

* Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
* Scripts/webkitdirs.pm:
(launcherName): Same.
* Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
* gtk/common.py:
(get_build_path.is_valid_build_directory): Same.
* gtk/manifest.txt: Same.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove "System Font" from character width calculations
https://bugs.webkit.org/show_bug.cgi?id=131411

Reviewed by Tim Horton.

Covered by existing tests

* platform/graphics/Font.cpp:
(WebCore::Font::hasValidAverageCharWidth):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@167082 268f45cc-cd09-0410-ab3c-d52691b4dbfc