Fix finding router for scenario tests

Finding router return tuple resp,body and body only contains router details.
Closes-Bug: 1375859
Change-Id: Ic405d20991561e8773153d829750826a82ed751c
Adds status check for FloatingIP in network scenarios

Verifies FloatingIP changes status correctly on association and dis-association

Scenarios:
test_network_basic_op
test_network_advanced_server_ops

Status is verified after connectivity check and without a waiter in order to
not mask unknown races in Neutron

Changes show() to refresh() to keep consistency

Partially Implements: blueprint fip-op-status (this is a Neutron bp:
https://blueprints.launchpad.net/neutron/+spec/fip-op-status)
Partially Implements: blueprint neutron-advanced-scenarios

Change-Id: Ibd45f3092cebc8f9fd0d16a3a543c2ef72156409
Add expected response checks of secgroup rules

"add security group rule" API returns additional rule in its response
body but current tests don't check the response.
This patch adds some checks of the response.
In addition, this patch removes status code checks because the codes
are already checked in client side.

Change-Id: Iab4ce492c060b8a2b79a3b3d9a6d30a359f6f312
Related-Bug: #1373832
Orchestration use stack timeout waiting for ping response

The test_server_cfn_init scenario test boots a full Fedora image,
not the cirros image which is presumably used for compute tests
where the default 120s ping timeout may be appropriate.

To ensure we don't encounter any spurious failures due to booting the
much bigger orchestration image (which is Fedora in the gate), use
the stack timeout (default 900s) to override the ping timeout for
this test.

Change-Id: I4eba18333bdaa0ef41122cda85fd3f4d91b2cf5c
Closes-Bug: #1374175
Add Credentials Provider factory

Add a method to select the appropriate credentials provider based
on configuration, and replace all the flow branches based on
allow_tenant_isolation to use the factory.

This also includes handling NotImplemented exceptions on admin creds
for scenarios tests which is a new potential condition by using the
factory.

Partially-implements bp:test-accounts

Change-Id: I280f2b1659c593e14ab9213a161b55bcfc08fa5c
Move status check to client for "messaging" tests

This patch moves the response status code check from
tests to client side.

NOTE- Some API return different success status code on fly so
leaving those status code specific check in tests only.

Partially Implements blueprint: client-checks-success

Change-Id: Ibbab26d6a99bf67eb684cc9c3ce7845c91fa092e
Fix cleanup for EC2 test_compute_with_volumes

Volume cleanup for test_compute_with_volumes fails when volume is in
"error" state.

cleanup part destroy_volume_wait() is to delete the volume and detach
before delete if necessary.
In destroy_volume_wait(), before detaching the volume there is checks if
volume status is not "available" but that is not sufficient enough to
guarantee that volume is attached. Volume status can be "error".

When something wrong happens with Volume and Volume is in "error"
state then, detach request will through the error as mentioned in
bug# 1310896.

Logic in destroy_volume_wait should be checking of state as "in-use" before
trying to detach volume. So that if it is in "in-use" state then detach and
go for volume delete. If not in "in-use" ("available" or  "error" etc) then
only go for volume delete.

Change-Id: I1882dbba947cc294cb4fe119db50f2a1c23b75be
Related-Bug: #1310896
Verify network interfaces are in requested order

There is no Tempest test verifying that the order of multiple networks passed
to an instance during its creation is preserved within the instance
(https://review.openstack.org/#/c/85711/). This change introduces a new test
in test_create_server to verify this feature.

Change-Id: I3622b9e8dfbbf73eb9a0a69d2094b75e4934fe17
Add missing space to build_timeout description

Change-Id: I2b4ceb5c4c795903454873a6d4882c563499186a
Merge "Verify network interfaces are in requested order"
Merge "Add Credentials Provider factory"
Merge "Orchestration use stack timeout waiting for ping response"
Merge "Adds status check for FloatingIP in network scenarios"
Merge "Add missing space to build_timeout description"
Merge "Fix cleanup for EC2 test_compute_with_volumes"
Merge "Fix finding router for scenario tests"
Merge "Move status check to client for "messaging" tests"
Merge "Add expected response checks of secgroup rules"
Merge branch 'master' of https://github.com/openstack/tempest