dataviewers: Cleanup.

Reduce visibility wherever possible - if new methods will be exposed
they have to have proper javadoc (both at class/method level). At
version 3.0 it's high time to take API seriously.
Also fix a number of inconsistencies as spotted by sonar.

Change-Id: I8640827f3c16cc89688ba93abe553e7665d2bc56
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24936
Tested-by: Hudson CI
changelog: Cleanups.

Overview of unused code and fix warnings identified by Sonar.

Change-Id: Icf4f23ea4453cc784c4f7416e18d0b5ac3119e75
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24937
Tested-by: Hudson CI
valgrind: Cleanup codebase.

* Make methods private.
* Remove unused methods.
* Removed redundant modifiers.
* Formatting and other issues spotted by Sonar.

Change-Id: I0de70e0a0ea9989bf911fecc66112512ea5e2885
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24950
Tested-by: Hudson CI
profiling: Fix warnings.

Sonar identified.

Change-Id: I64b606b3856afbaa4f96c49797d475664554e465
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24957
Tested-by: Hudson CI
rpm: Tighten up requirement on org.eclipse.ui.workbench.texteditor

Due to making a platform API call that is only available in Luna+

Change-Id: Ide35d18320a97cf95f3367d5a25c040a55ab2ef7
Signed-off-by: Mat Booth <mat.booth@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24982
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Do not attempt to save a disposed chart.

Change-Id: I0781341423dd7c436f2b7f67db8396811abcb40c
Reviewed-on: https://git.eclipse.org/r/24980
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>
Systemtap: Improve tapset importing.

-Clicking the "Import Tapsets" now opens the Tapsets Preferences
page instead of a file dialog.

-Changes made to imported tapsets immediately refresh the available
functions & probes listed in the Function & Probe Alias views (EBZ #429597).

Change-Id: Id6e9a70c6f59e8084900b201fda6d052d937dd7d
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/23408
Reviewed-by: Sami Wagiaalla <swagiaal@redhat.com>
Tested-by: Sami Wagiaalla <swagiaal@redhat.com>
ctf: Use Antlr 3.5.2 for parser generation only

This change keeps the Antlr rutime at the same version (3.2)
but upgrades to 3.5.2 at the parser generation time (maven)
so that it builds with Java 8.

Change-Id: If9969034777534671d9ec23b19495ce2cf341fdb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24821
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
callgraph: Remove dead code.

And other small changes as spotted.

Change-Id: I38b8ad2fd60d7263b3a88aae491e822fdca153e4
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24985
Tested-by: Hudson CI
ctf/tmf: allow multiple traces to be open with name clashing events

This is a problem not yet encountered but that will be a showstopper.
If you have two traces with event definitions that have the same name
but different payloads the second one will override the first.

This means that if I have two traces with events that are named "bob"
and we have a state provider for each that looks up different fields
in "bob", one will no longer return the correct values and exceptions
will be thrown everywhere.

Change-Id: I05f9bc0fbbd67374fcf3680d75fcb769c4f32a3a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23285
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
tmf: Fix drag and drop to experiment unnecessarily prompts for rename

When dropping a trace to an experiment in the same project, name
collision occured and the user was prompted for rename.

Change-Id: I0db0d81610a7afbb1df762838bf2129db510c962
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24884
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
tmf: allow intervals with variable size

Remove the fix data size of a HTInterval in HTNode.

Change-Id: I116053884328318379a72643e7c4bf64b3b912c0
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/24795
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
systemtap: Remove dead code all around.

And fix small inconsitencies as spotted.

Change-Id: I7c4a63e9dbaa7651630b26068bb1df30cf3e0bcd
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24992
oprofile/perf: Remove dead code.

And other small changes wherever spotted.

Change-Id: I19616bd1a052d8ec2cf873553bb36a7c45057beb
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/24996
Tested-by: Hudson CI
valgrind: Merge the 3 Expand/Collapse action implementation.

There is no need to have that code copied all around. Make it a single
copy and expor as API.
As this is new API tighten the rules for javadoc so warnings are shown
for all public field/methods that don't have proper one.

Change-Id: I5916d2b5ce6b05968696ae1d8d4ebd79dd2f4dcc
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25022
Tested-by: Hudson CI
rpm: Sonar warning fixes.

Change-Id: Iea6c3e579225da9e0582a3ff005ebc3c80ac0df2
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25026
Tested-by: Hudson CI
valgrind: Another round of cleanups.

Thanks to Sonar spotting them.

Change-Id: Ica63ed978266d480baa416a56342aad7a3175fef
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25030
Tested-by: Hudson CI
gcov: Fix warnings.

Thanks to Sonar for identifying them.

Change-Id: I1a20b2a0e752860e1d558fab82ab3b3689153ac2
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25033
Tested-by: Hudson CI
oprofile: Fix warnings.

As identified by Sonar.

Change-Id: I1b68ee593df699d19372edf1a28e8ec913dab1ae
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25048
Tested-by: Hudson CI
gprof: All kind of warning fixes.

Identified by Sonar.

Change-Id: Ibdf80281657598fd30604b5044f7940f6af0547f
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25047
Tested-by: Hudson CI